From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932962AbcCNTio (ORCPT ); Mon, 14 Mar 2016 15:38:44 -0400 Received: from smtprelay0243.hostedemail.com ([216.40.44.243]:50915 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932338AbcCNTim (ORCPT ); Mon, 14 Mar 2016 15:38:42 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:2892:3138:3139:3140:3141:3142:3355:3622:3865:3867:3868:3870:3871:3872:3874:4321:5007:6119:6261:7903:10004:10400:10848:11026:11232:11658:11914:12043:12296:12438:12517:12519:12740:13439:13894:14659:14721:21080:21324:30054:30070:30075:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: jewel88_2e6d4eff8152c X-Filterd-Recvd-Size: 3604 Message-ID: <1457984317.11972.123.camel@perches.com> Subject: Re: [PATCH] rtc: s3c: Don't print an error on probe deferral From: Joe Perches To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Alexandre Belloni , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , rtc-linux@googlegroups.com Date: Mon, 14 Mar 2016 12:38:37 -0700 In-Reply-To: <56E7119B.9060900@osg.samsung.com> References: <1457982308-29848-1-git-send-email-javier@osg.samsung.com> <1457982675.11972.119.camel@perches.com> <56E7119B.9060900@osg.samsung.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-03-14 at 16:31 -0300, Javier Martinez Canillas wrote: > On 03/14/2016 04:11 PM, Joe Perches wrote:> > On Mon, 2016-03-14 at 16:05 -0300, Javier Martinez Canillas wrote: > > > > > > The clock and source clock looked up by the driver may not be available > > > just because the clock controller driver was not probed yet so printing > > > an error in this case is not correct and only adds confusion to users. > > > > > > However, knowing that a driver's probe was deferred may be useful so it > > > can be printed as debug information. > > [] > > > > > > diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c > > [] > > > > > > @@ -501,18 +501,27 @@ static int s3c_rtc_probe(struct platform_device *pdev) > > >   > > >   info->rtc_clk = devm_clk_get(&pdev->dev, "rtc"); > > >   if (IS_ERR(info->rtc_clk)) { > > > - dev_err(&pdev->dev, "failed to find rtc clock\n"); > > > - return PTR_ERR(info->rtc_clk); > > > + ret = PTR_ERR(info->rtc_clk); > > > + if (ret != -EPROBE_DEFER) > > > + dev_err(&pdev->dev, "failed to find rtc clock\n"); > > > + else > > > + dev_dbg(&pdev->dev, "probe deferred due rtc clock\n"); > > > + return ret; > > >   } > > >   clk_prepare_enable(info->rtc_clk); > > >   > > >   if (info->data->needs_src_clk) { > > >   info->rtc_src_clk = devm_clk_get(&pdev->dev, "rtc_src"); > > >   if (IS_ERR(info->rtc_src_clk)) { > > > - dev_err(&pdev->dev, > > > - "failed to find rtc source clock\n"); > > > + ret = PTR_ERR(info->rtc_src_clk); > > > + if (ret != -EPROBE_DEFER) > > > + dev_err(&pdev->dev, > > > + "failed to find rtc source clock\n"); > > > + else > > > + dev_dbg(&pdev->dev, > > > + "probe deferred due rtc source clock\n"); > > >   clk_disable_unprepare(info->rtc_clk); > > > - return PTR_ERR(info->rtc_src_clk); > > > + return ret; > > >   } > > >   clk_prepare_enable(info->rtc_src_clk); > > >   } > > Maybe the debug logging messages could be object->action like: > > > > rtc clock probe deferred > > rtc source clock probe deferred > > > I found your suggested messages harder to read and more confusing. The > action that happens is a probe function deferral and that is caused by > a missing resource needed by the driver (clocks in this case). > > But your messages seems to imply that the probe deferred action happens > to a clock, it sounds like "rtc clock disabled" and that's not correct. OK, then please change "due" to "due to" or "for" in your messages because they make little sense now.