public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
	linux-kernel@vger.kernel.org
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	linux-samsung-soc@vger.kernel.org,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	rtc-linux@googlegroups.com
Subject: Re: [PATCH v2] rtc: s3c: Don't print an error on probe deferral
Date: Mon, 14 Mar 2016 13:30:53 -0700	[thread overview]
Message-ID: <1457987453.11972.133.camel@perches.com> (raw)
In-Reply-To: <1457987157-1177-1-git-send-email-javier@osg.samsung.com>

On Mon, 2016-03-14 at 17:25 -0300, Javier Martinez Canillas wrote:
> The clock and source clock looked up by the driver may not be available
> just because the clock controller driver was not probed yet so printing
> an error in this case is not correct and only adds confusion to users.
> 
> However, knowing that a driver's probe was deferred may be useful so it
> can be printed as debug information.

Hello again Javier:
> +			dev_dbg(&pdev->dev, "probe deferred due missing rtc clk\n");

Again, intelligible English would not use "due"
but would use "due to" or "because of".

> +				dev_dbg(&pdev->dev,
> +					"probe deferred due missing rtc src clk\n");

here too.

  reply	other threads:[~2016-03-14 20:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14 20:25 [PATCH v2] rtc: s3c: Don't print an error on probe deferral Javier Martinez Canillas
2016-03-14 20:30 ` Joe Perches [this message]
2016-03-14 21:07   ` Javier Martinez Canillas
2016-03-14 22:58     ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457987453.11972.133.camel@perches.com \
    --to=joe@perches.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=javier@osg.samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox