From: Joe Perches <joe@perches.com>
To: Arnd Bergmann <arnd@arndb.de>, "David S . Miller" <davem@davemloft.net>
Cc: Marcin Wojtas <mw@semihalf.com>, Evan Wang <xswang@marvell.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
netdev@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Nicolas Schichan <nschichan@freebox.fr>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: mvebu-mbus: use %pad to print phys_addr_t
Date: Tue, 15 Mar 2016 03:09:00 -0700 [thread overview]
Message-ID: <1458036540.11972.183.camel@perches.com> (raw)
In-Reply-To: <1458036233-2770406-1-git-send-email-arnd@arndb.de>
On Tue, 2016-03-15 at 11:03 +0100, Arnd Bergmann wrote:
> A recent change to the mbus driver added a warning printk that
> prints a phys_addr_t using the %x format string, which fails in
> case we build with 64-bit phys_addr_t:
Hey Arnd.
This is a bad patch subject, %pad is for a dma_addr_t.
The patch subject made me assume the patch was incorrect.
> > This uses the special %pa format string instead, so we always
> print the correct type.
[]
> - pr_err("invalid dram address 0x%x\n", phyaddr);
> + pr_err("invalid dram address %pa\n", &phyaddr);
The patch is good though.
next prev parent reply other threads:[~2016-03-15 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 10:03 [PATCH] bus: mvebu-mbus: use %pad to print phys_addr_t Arnd Bergmann
2016-03-15 10:09 ` Joe Perches [this message]
2016-03-29 16:04 ` Gregory CLEMENT
2016-03-29 19:51 ` Arnd Bergmann
2016-03-30 9:37 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458036540.11972.183.camel@perches.com \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=nschichan@freebox.fr \
--cc=thomas.petazzoni@free-electrons.com \
--cc=xswang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox