From: Paul Bolle <pebolle@tiscali.nl>
To: Michal Marek <mmarek@suse.com>
Cc: Josh Boyer <jwboyer@fedoraproject.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] kconfig: add chomp like helper function
Date: Wed, 16 Mar 2016 13:41:56 +0100 [thread overview]
Message-ID: <1458132116.2631.7.camel@tiscali.nl> (raw)
In-Reply-To: <56E946A1.2060400@suse.com>
On wo, 2016-03-16 at 12:42 +0100, Michal Marek wrote:
> For this particular use, it's probably easier to just write
>
> conf_warning("unexpected data: %.*s",
> (int)strcspn(line, "\r\n"), line);
OK. (Next time I'll try listen to the voice in my head whispering:
"There must be an easier way to do this.".)
> Or do you see more use cases for the chomp function?
No.
> No matter how the string is constructed, I like the verbose warning :)
I'll respin and resend (in a few hours).
Thanks,
Paul Bolle
prev parent reply other threads:[~2016-03-16 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 10:53 [PATCH 1/2] kconfig: add chomp like helper function Paul Bolle
2016-03-16 10:53 ` [PATCH 2/2] kconfig: add unexpected data itself to warning Paul Bolle
2016-03-16 11:42 ` [PATCH 1/2] kconfig: add chomp like helper function Michal Marek
2016-03-16 12:41 ` Paul Bolle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458132116.2631.7.camel@tiscali.nl \
--to=pebolle@tiscali.nl \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox