From: Eric Anholt <eric@anholt.net>
To: linux-rpi-kernel@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Vinod Koul <vinod.koul@intel.com>,
dmaengine@vger.kernel.org, Martin Sperl <kernel@martin.sperl.org>,
Eric Anholt <eric@anholt.net>
Subject: [PATCH 2/8] dmaengine: bcm2835: remove unnecessary masking of dma channels
Date: Wed, 16 Mar 2016 12:24:56 -0700 [thread overview]
Message-ID: <1458156302-4359-3-git-send-email-eric@anholt.net> (raw)
In-Reply-To: <1458156302-4359-1-git-send-email-eric@anholt.net>
From: Martin Sperl <kernel@martin.sperl.org>
The original patch contained 3 dma channels that were masked out.
These - as far as research and discussions show - are a
artefacts remaining from the downstream legacy dma-api.
Right now down-stream still includes a legacy api used only
in a single (downstream only) driver (bcm2708_fb) that requires
2D DMA for speedup (DMA-channel 0).
Formerly the sd-card support driver also was using this legacy
api (DMA-channel 2), but since has been moved over to use
dmaengine directly.
The DMA-channel 3 is already masked out in the devicetree in
the default property "brcm,dma-channel-mask = <0x7f35>;"
So we can remove the whole masking of DMA channels.
Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Eric Anholt <eric@anholt.net>
---
drivers/dma/bcm2835-dma.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index 2d72fe8..e4ca980 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -123,9 +123,6 @@ struct bcm2835_desc {
#define BCM2835_DMA_DATA_TYPE_S32 4
#define BCM2835_DMA_DATA_TYPE_S128 16
-#define BCM2835_DMA_BULK_MASK BIT(0)
-#define BCM2835_DMA_FIQ_MASK (BIT(2) | BIT(3))
-
/* Valid only for channels 0 - 14, 15 has its own base address */
#define BCM2835_DMA_CHAN(n) ((n) << 8) /* Base address */
#define BCM2835_DMA_CHANIO(base, n) ((base) + BCM2835_DMA_CHAN(n))
@@ -641,12 +638,6 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
goto err_no_dma;
}
- /*
- * Do not use the FIQ and BULK channels,
- * because they are used by the GPU.
- */
- chans_available &= ~(BCM2835_DMA_FIQ_MASK | BCM2835_DMA_BULK_MASK);
-
for (i = 0; i < pdev->num_resources; i++) {
irq = platform_get_irq(pdev, i);
if (irq < 0)
--
2.7.0
next prev parent reply other threads:[~2016-03-16 19:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 19:24 [PATCH 0/8 v4] bcm2835 DMA slave support Eric Anholt
2016-03-16 19:24 ` [PATCH 1/8] dmaengine: bcm2835: set residue_granularity field Eric Anholt
2016-03-16 19:24 ` Eric Anholt [this message]
2016-03-16 19:24 ` [PATCH 3/8] dmaengine: bcm2835: add additional defines for DMA-registers Eric Anholt
2016-03-16 19:24 ` [PATCH 4/8] dmaengine: bcm2835: move cyclic member from bcm2835_chan into bcm2835_desc Eric Anholt
2016-03-16 19:24 ` [PATCH 5/8] dmaengine: bcm2835: move controlblock chain generation into separate method Eric Anholt
2016-03-16 19:25 ` [PATCH 6/8] dmaengine: bcm2835: limit max length based on channel type Eric Anholt
2016-03-16 19:25 ` [PATCH 7/8] dmaengine: bcm2835: add slave_sg support to bcm2835-dma Eric Anholt
2016-03-16 19:25 ` [PATCH 8/8] dmaengine: bcm2835: add dma_memcopy " Eric Anholt
2016-03-17 10:22 ` [PATCH 0/8 v4] bcm2835 DMA slave support Martin Sperl
2016-03-17 13:17 ` Martin Sperl
2016-04-05 18:03 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458156302-4359-3-git-send-email-eric@anholt.net \
--to=eric@anholt.net \
--cc=dmaengine@vger.kernel.org \
--cc=kernel@martin.sperl.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=swarren@wwwdotorg.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox