From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936677AbcCQUdf (ORCPT ); Thu, 17 Mar 2016 16:33:35 -0400 Received: from smtprelay0155.hostedemail.com ([216.40.44.155]:56685 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934427AbcCQUdd (ORCPT ); Thu, 17 Mar 2016 16:33:33 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3867:3868:4031:4078:4081:4321:5007:6261:10004:10400:10848:11026:11232:11473:11658:11783:11914:12043:12438:12517:12519:12740:13069:13311:13357:13439:13894:14659:14721:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: fight31_760f8241be118 X-Filterd-Recvd-Size: 1639 Message-ID: <1458246810.9556.22.camel@perches.com> Subject: Re: [PATCH v2 1/2] iommu/vt-d: Ratelimit fault handler From: Joe Perches To: Alex Williamson , iommu@lists.linux-foundation.org, dwmw2@infradead.org Cc: joro@8bytes.org, linux-kernel@vger.kernel.org Date: Thu, 17 Mar 2016 13:33:30 -0700 In-Reply-To: <20160317201225.29049.43163.stgit@gimli.home> References: <20160317200557.29049.32879.stgit@gimli.home> <20160317201225.29049.43163.stgit@gimli.home> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-03-17 at 14:12 -0600, Alex Williamson wrote: > Fault rates can easily overwhelm the console and make the system > unresponsive.  Ratelimit to allow an opportunity for maintenance. [] > diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c [] > @@ -1602,10 +1602,17 @@ irqreturn_t dmar_fault(int irq, void *dev_id) >   int reg, fault_index; >   u32 fault_status; >   unsigned long flag; > + bool ratelimited; > + static DEFINE_RATELIMIT_STATE(rs, > +       DEFAULT_RATELIMIT_INTERVAL, > +       DEFAULT_RATELIMIT_BURST); Are these the appropriate limits for dmar? include/linux/ratelimit.h:#define DEFAULT_RATELIMIT_INTERVAL    (5 * HZ) include/linux/ratelimit.h:#define DEFAULT_RATELIMIT_BURST       10