public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ley Foon Tan <lftan@altera.com>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	<nios2-dev@lists.rocketboards.org>,
	<linux-kernel@vger.kernel.org>, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH] nios2: Replace fdt_translate_address with of_flat_dt_translate_address
Date: Fri, 18 Mar 2016 13:58:03 +0800	[thread overview]
Message-ID: <1458280683.2963.11.camel@ubuntu> (raw)
In-Reply-To: <56EB7478.9080401@hurleysoftware.com>

On Thu, 2016-03-17 at 20:22 -0700, Peter Hurley wrote:
> Hi Guenter,
> 
> On 03/17/2016 07:49 PM, Guenter Roeck wrote:
> > nios2 builds fail with the following build error.
> > 
> > arch/nios2/kernel/prom.c: In function 'early_init_dt_scan_serial':
> > arch/nios2/kernel/prom.c:100:2: error:
> > 	implicit declaration of function 'fdt_translate_address'
> > 
> > Commit c90fe9c0394b ("of: earlycon: Move address translation to
> > of_setup_earlycon()") replaced fdt_translate_address() with
> > of_flat_dt_translate_address() but missed updating the nios2 code.
> 
> My bad.
> The sad part is I even noted this other user of fdt_translate_address()
> in a review of a different patch, and then overlooked it in my own patch. :/
> 
> Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
> 
Hi Peter,

Will you take this patch or you want me to take this?
Thanks.

Regards
Ley Foon

  reply	other threads:[~2016-03-18  6:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18  2:49 [PATCH] nios2: Replace fdt_translate_address with of_flat_dt_translate_address Guenter Roeck
2016-03-18  3:22 ` Peter Hurley
2016-03-18  5:58   ` Ley Foon Tan [this message]
2016-03-18 13:28     ` Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458280683.2963.11.camel@ubuntu \
    --to=lftan@altera.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nios2-dev@lists.rocketboards.org \
    --cc=peter@hurleysoftware.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox