Re: Nokia N900 - audio TPA6130A2 problems

Mark Brown
2016-03-21T12:04:20Z

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

On Mon, Mar 21, 2016 at 01:04:18AM +0100, Sebastian Reichel wrote:

> Right thinking about it, the voltage must also be configured for the
> non always-on cases. So it's not a problem with the regulator
> framework, but with twl-regulator's probe function, that should take
> care of this.

Absolutely not! Like all other regulator drivers the twl driver should
be taking no decisions about what voltage to set except in response to a
set_voltage() call. All the logic about setting voltages is factored
out into the core.

Please try to understand the abstractions we're using in the framework.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]