From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757783AbcCRRmJ (ORCPT ); Fri, 18 Mar 2016 13:42:09 -0400 Received: from smtprelay0199.hostedemail.com ([216.40.44.199]:39735 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757216AbcCRRmH (ORCPT ); Fri, 18 Mar 2016 13:42:07 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3873:3874:4250:4321:5007:6117:6119:6261:7903:9038:10004:10400:10848:11232:11658:11914:12296:12517:12519:12679:12740:13069:13311:13357:13439:14659:14721:21080:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: stick29_86611b0199022 X-Filterd-Recvd-Size: 1987 Message-ID: <1458322922.26915.5.camel@perches.com> Subject: Re: [PATCH 1/2] watchdog: Fix output From: Joe Perches To: Peter Zijlstra , Don Zickus Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org, mingo@kernel.org, tglx@linutronix.de Date: Fri, 18 Mar 2016 10:42:02 -0700 In-Reply-To: <20160318164858.GX6375@twins.programming.kicks-ass.net> References: <20160318152802.407611377@infradead.org> <20160318153022.027826871@infradead.org> <20160318163748.GR64531@redhat.com> <20160318164441.GI6344@twins.programming.kicks-ass.net> <20160318164858.GX6375@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-03-18 at 17:48 +0100, Peter Zijlstra wrote: > On Fri, Mar 18, 2016 at 05:44:41PM +0100, Peter Zijlstra wrote: > > > > On Fri, Mar 18, 2016 at 12:37:48PM -0400, Don Zickus wrote: > > > > > > Would something like this be a better patch? > > > > > > -#define pr_fmt(fmt) "NMI watchdog: " fmt > > > +#define pr_fmt(fmt) "Lockup detector: " fmt > You might want to audit all the other pr_ nonsense in that file; a > lot > of the msgs don't particularly make sense when combined with the > prefix. > > Some are for the NMI thing, others for the soft lockup one. > > I would just chuck pr_crap() altogether and use sensible text. or change to #define pr_fmt(fmt) fmt and output whatever unprefixed content you want. btw: the first printk/pr_emerg should add a newline pr_emerg("Watchdog detected hard LOCKUP on cpu %d", this_cpu); sb: pr_emerg("Watchdog detected hard LOCKUP on cpu %d\n", this_cpu);