From: Joe Perches <joe@perches.com>
To: Parth Sane <laerdevstudios@gmail.com>, gregkh@linuxfoundation.org
Cc: brcnakalin@gmail.com, shraddha.6596@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning
Date: Sat, 19 Mar 2016 12:37:07 -0700 [thread overview]
Message-ID: <1458416227.4228.4.camel@perches.com> (raw)
In-Reply-To: <1458412550-17021-1-git-send-email-laerdevstudios@gmail.com>
On Sat, 2016-03-19 at 18:35 +0000, Parth Sane wrote:
> Fixed alignment of paranthesis as per checkpatch.
Please run your proposed patches through checkpatch.
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
[]
> @@ -121,9 +121,7 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
> ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
> ndata1.phy_addr[mac] = mac + 4 + 0x10;
>
> - xlr_resource_init(&xlr_net1_res[mac * 2],
> - xlr_gmac_offsets[mac + 4],
> - xlr_gmac_irqs[mac + 4]);
> + xlr_resource_init(&xlr_net1_res[mac * 2], xlr_gmac_offsets[mac + 4], xlr_gmac_irqs[mac + 4]);
More typical is to avoid exceeding 80 columns
and wrap this line like:
xlr_resource_init(&xlr_net1_res[mac * 2],
xlr_gmac_offsets[mac + 4],
xlr_gmac_irqs[mac + 4]);
Indenting the 2nd and 3rd lines with 4 tabs and 2 spaces
next prev parent reply other threads:[~2016-03-19 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 18:35 [PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning Parth Sane
2016-03-19 19:37 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-03-20 1:42 Parth Sane
2016-03-20 1:47 ` Joe Perches
2016-03-19 18:33 Parth Sane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458416227.4228.4.camel@perches.com \
--to=joe@perches.com \
--cc=brcnakalin@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=laerdevstudios@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox