[PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning

[PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning

[Parth Sane]

From: Ubuntu <ubuntu@ip-172-31-28-98.ap-southeast-1.compute.internal>

Fixed alignment of paranthesis as per checkpatch.

Signed-off-by: Parth Sane <laerdevstudios@gmail.com>

---
 drivers/staging/netlogic/platform_net.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
index daee1b2..82af021 100644
--- a/drivers/staging/netlogic/platform_net.c
+++ b/drivers/staging/netlogic/platform_net.c
@@ -121,9 +121,7 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
 		ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
 		ndata1.phy_addr[mac] = mac + 4 + 0x10;
 
-		xlr_resource_init(&xlr_net1_res[mac * 2],
-				xlr_gmac_offsets[mac + 4],
-				xlr_gmac_irqs[mac + 4]);
+		xlr_resource_init(&xlr_net1_res[mac * 2], xlr_gmac_offsets[mac + 4], xlr_gmac_irqs[mac + 4]);
 	}
 	xlr_net_dev1.num_resources = 8;
 
-- 
1.9.1

[PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning

[Parth Sane]

Fixed alignment of paranthesis as per checkpatch.

Signed-off-by: Parth Sane <laerdevstudios@gmail.com>

---
 drivers/staging/netlogic/platform_net.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
index daee1b2..82af021 100644
--- a/drivers/staging/netlogic/platform_net.c
+++ b/drivers/staging/netlogic/platform_net.c
@@ -121,9 +121,7 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
 		ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
 		ndata1.phy_addr[mac] = mac + 4 + 0x10;
 
-		xlr_resource_init(&xlr_net1_res[mac * 2],
-				xlr_gmac_offsets[mac + 4],
-				xlr_gmac_irqs[mac + 4]);
+		xlr_resource_init(&xlr_net1_res[mac * 2], xlr_gmac_offsets[mac + 4], xlr_gmac_irqs[mac + 4]);
 	}
 	xlr_net_dev1.num_resources = 8;
 
-- 
1.9.1

Re: [PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning

[Joe Perches]

On Sat, 2016-03-19 at 18:35 +0000, Parth Sane wrote:
> Fixed alignment of paranthesis as per checkpatch.

Please run your proposed patches through checkpatch.
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
[]
> @@ -121,9 +121,7 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
>  		ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
>  		ndata1.phy_addr[mac] = mac + 4 + 0x10;
>  
> -		xlr_resource_init(&xlr_net1_res[mac * 2],
> -				xlr_gmac_offsets[mac + 4],
> -				xlr_gmac_irqs[mac + 4]);
> +		xlr_resource_init(&xlr_net1_res[mac * 2], xlr_gmac_offsets[mac + 4], xlr_gmac_irqs[mac + 4]);

More typical is to avoid exceeding 80 columns
and wrap this line like:

		xlr_resource_init(&xlr_net1_res[mac * 2],
				  xlr_gmac_offsets[mac + 4],
				  xlr_gmac_irqs[mac + 4]);

Indenting the 2nd and 3rd lines with 4 tabs and 2 spaces

[PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning

[Parth Sane]

Fixed alignment of paranthesis as per checkpatch. Please ignore earlier sent patch for paranthesis check and use this one. 
Signed-off-by: Parth Sane <laerdevstudios@gmail.com>

---
 drivers/staging/netlogic/platform_net.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
index daee1b2..dde20d5 100644
--- a/drivers/staging/netlogic/platform_net.c
+++ b/drivers/staging/netlogic/platform_net.c
@@ -120,10 +120,9 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
 	for (mac = 0; mac < 4; mac++) {
 		ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
 		ndata1.phy_addr[mac] = mac + 4 + 0x10;
-
 		xlr_resource_init(&xlr_net1_res[mac * 2],
-				xlr_gmac_offsets[mac + 4],
-				xlr_gmac_irqs[mac + 4]);
+				  xlr_gmac_offsets[mac + 4],
+				  xlr_gmac_irqs[mac + 4]);
 	}
 	xlr_net_dev1.num_resources = 8;
 
-- 
1.9.1

Re: [PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning

[Joe Perches]

On Sun, 2016-03-20 at 01:42 +0000, Parth Sane wrote:
> Fixed alignment of paranthesis as per checkpatch.

The subject prefix [PATCH] should be numbered
with the revision like [PATCH v2]

> Please ignore earlier sent patch for paranthesis check and use this one. 

This bit of your email should go below the ---
separator line.

Otherwise it goes into the git commit log which
isn't desired.

Trivially, you've misspelled parenthesis

> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
> 
> ---
>  drivers/staging/netlogic/platform_net.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
> index daee1b2..dde20d5 100644
> --- a/drivers/staging/netlogic/platform_net.c
> +++ b/drivers/staging/netlogic/platform_net.c
> @@ -120,10 +120,9 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
>  	for (mac = 0; mac < 4; mac++) {
>  		ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
>  		ndata1.phy_addr[mac] = mac + 4 + 0x10;
> -

Also trivially, there's no reason to delete this line.

>  		xlr_resource_init(&xlr_net1_res[mac * 2],
> -				xlr_gmac_offsets[mac + 4],
> -				xlr_gmac_irqs[mac + 4]);
> +				  xlr_gmac_offsets[mac + 4],
> +				  xlr_gmac_irqs[mac + 4]);
>  	}
>  	xlr_net_dev1.num_resources = 8;
>