From: Joe Perches <joe@perches.com>
To: Parth Sane <laerdevstudios@gmail.com>, gregkh@linuxfoundation.org
Cc: brcnakalin@gmail.com, shraddha.6596@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning
Date: Sat, 19 Mar 2016 18:47:43 -0700 [thread overview]
Message-ID: <1458438463.4228.10.camel@perches.com> (raw)
In-Reply-To: <1458438174-17566-1-git-send-email-laerdevstudios@gmail.com>
On Sun, 2016-03-20 at 01:42 +0000, Parth Sane wrote:
> Fixed alignment of paranthesis as per checkpatch.
The subject prefix [PATCH] should be numbered
with the revision like [PATCH v2]
> Please ignore earlier sent patch for paranthesis check and use this one.
This bit of your email should go below the ---
separator line.
Otherwise it goes into the git commit log which
isn't desired.
Trivially, you've misspelled parenthesis
> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
>
> ---
> drivers/staging/netlogic/platform_net.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
> index daee1b2..dde20d5 100644
> --- a/drivers/staging/netlogic/platform_net.c
> +++ b/drivers/staging/netlogic/platform_net.c
> @@ -120,10 +120,9 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
> for (mac = 0; mac < 4; mac++) {
> ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
> ndata1.phy_addr[mac] = mac + 4 + 0x10;
> -
Also trivially, there's no reason to delete this line.
> xlr_resource_init(&xlr_net1_res[mac * 2],
> - xlr_gmac_offsets[mac + 4],
> - xlr_gmac_irqs[mac + 4]);
> + xlr_gmac_offsets[mac + 4],
> + xlr_gmac_irqs[mac + 4]);
> }
> xlr_net_dev1.num_resources = 8;
>
next prev parent reply other threads:[~2016-03-20 1:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 1:42 [PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning Parth Sane
2016-03-20 1:47 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-03-19 18:35 Parth Sane
2016-03-19 19:37 ` Joe Perches
2016-03-19 18:33 Parth Sane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458438463.4228.10.camel@perches.com \
--to=joe@perches.com \
--cc=brcnakalin@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=laerdevstudios@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox