[PATCH v3] staging: netlogic: Fixed alignment of parentheseis checkpatch warning

[PATCH v3] staging: netlogic: Fixed alignment of parentheseis checkpatch warning

[Parth Sane]

Fixed alignment of parenthesis checkpatch warning to fit coding standards.

Signed-off-by: Parth Sane <laerdevstudios@gmail.com>

---
 drivers/staging/netlogic/platform_net.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
index dde20d5..c967543 100644
--- a/drivers/staging/netlogic/platform_net.c
+++ b/drivers/staging/netlogic/platform_net.c
@@ -168,8 +168,9 @@ static void xls_gmac_init(void)
 
 		xlr_net_dev0.num_resources = 2;
 
-		xlr_resource_init(&xlr_net0_res[0], xlr_gmac_offsets[0],
-				xlr_gmac_irqs[0]);
+		xlr_resource_init(&xlr_net0_res[0],
+				  xlr_gmac_offsets[0],
+				  xlr_gmac_irqs[0]);
 		platform_device_register(&xlr_net_dev0);
 
 		/* second block is XAUI, not supported yet */
-- 
1.9.1

Re: [PATCH v3] staging: netlogic: Fixed alignment of parentheseis checkpatch warning

[Joe Perches]

On Sun, 2016-03-20 at 02:03 +0000, Parth Sane wrote:
> Fixed alignment of parenthesis checkpatch warning to fit coding
> standards.

This isn't the same code block as your previous patch.

Previously you were modifying the block starting at line 120,
this is starting at 168 and it doesn't actually need modification.

Also, you are not making this patch against either
Greg KH's staging-next or Stephen Rothwell's -next

This change has already been done by:

commit 3a694d0c294a081cc13a16c7e43d8cb473edf350
Author: Laura Garcia Liebana <nevola@gmail.com>
Date:   Wed Feb 17 09:46:35 2016 +0100

    staging: netlogic: Fix several parentheses alignments
    
    Align arguments with the open parenthesis. Checkpatch found these
    issues.
    
    Signed-off-by: Laura Garcia Liebana <nevola@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Re: [PATCH v3] staging: netlogic: Fixed alignment of parentheseis checkpatch warning

[Parth Sane]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

Hi,
Thanks for pointing out that the changes have been done. Nevertheless this was a good learning exercise. How do I check which changes have already been done? I’m planning to send in another patch on a blank line warning on the same file. I don’t want to overburden the mailing list by repeating work. I apologise for any inconvenience.
Regards,
Parth Sane



[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 842 bytes --]

Re: [PATCH v3] staging: netlogic: Fixed alignment of parentheseis checkpatch warning

[Joe Perches]

On Sun, 2016-03-20 at 07:48 +0530, Parth Sane wrote:
> Hi,
> Thanks for pointing out that the changes have been done. Nevertheless
> this was a good learning exercise. How do I check which changes have
> already been done?

Use this tree:

http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git

Re: [PATCH v3] staging: netlogic: Fixed alignment of parentheseis checkpatch warning

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

On Sat, 19 Mar 2016 19:22:09 -0700, Joe Perches said:
> On Sun, 2016-03-20 at 07:48 +0530, Parth Sane wrote:
> > Hi,
> > Thanks for pointing out that the changes have been done. Nevertheless
> > this was a good learning exercise. How do I check which changes have
> > already been done?
>
> Use this tree:
>
> http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git

And note that doing a 'git clone' of this won't do what you want..

What you *want* to do:

$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
$ git remote add linux-next git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
$ git fetch --tags linux-next

This will get you a tree that you can actually work with...
... # later on (linux-next is updated most weekdays)
$ git remote update
to find out what the current tree looks like.

You do *not* want to use 'git pull' against linux-next because it rebases
every night....


[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]