public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Parth Sane <laerdevstudios@gmail.com>, gregkh@linuxfoundation.org
Cc: florian.c.schilhabel@googlemail.com, Larry.Finger@lwfinger.net,
	hemmo.nieminen@iki.fi, punitvara@gmail.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Removed copyright notice
Date: Sun, 20 Mar 2016 02:29:24 -0700	[thread overview]
Message-ID: <1458466164.4228.21.camel@perches.com> (raw)
In-Reply-To: <1458444727-24017-1-git-send-email-laerdevstudios@gmail.com>

On Sun, 2016-03-20 at 03:32 +0000, Parth Sane wrote:
> Removed copyright notice as per checkpatch check warning.

This is not a good patch subject nor commit message.

Removing copyright is a serious thing.
You are not doing that.

You are removing a paragraph about an organization's
address that is subject to change.

Please be more thoughtful about what you are actually
doing when writing your commit subject lines and
messages.


> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
> 
> ---
>  drivers/staging/rtl8712/drv_types.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> index 29e47e1..ae79047 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -11,10 +11,6 @@
>   * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
>   * more details.
>   *
> - * You should have received a copy of the GNU General Public License along with
> - * this program; if not, write to the Free Software Foundation, Inc.,
> - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
> - *
>   * Modifications for inclusion into the Linux staging tree are
>   * Copyright(c) 2010 Larry Finger. All rights reserved.
>   *

      reply	other threads:[~2016-03-20  9:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-20  3:32 [PATCH] staging: rtl8712: Removed copyright notice Parth Sane
2016-03-20  9:29 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458466164.4228.21.camel@perches.com \
    --to=joe@perches.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hemmo.nieminen@iki.fi \
    --cc=laerdevstudios@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=punitvara@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox