* [PATCH] staging: rtl8712: Removed FSF address warning
@ 2016-03-20 14:13 Parth Sane
0 siblings, 0 replies; 6+ messages in thread
From: Parth Sane @ 2016-03-20 14:13 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, florian.c.schilhabel, devel, linux-kernel,
punitvara, luisbg, Parth Sane
Removed checkpatch warning caused due to FSF address paragraph
Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
---
drivers/staging/rtl8712/mlme_linux.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c
index e4e4bde..f124d72 100644
--- a/drivers/staging/rtl8712/mlme_linux.c
+++ b/drivers/staging/rtl8712/mlme_linux.c
@@ -13,10 +13,6 @@
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
* Modifications for inclusion into the Linux staging tree are
* Copyright(c) 2010 Larry Finger. All rights reserved.
*
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: rtl8712: Removed FSF address warning
@ 2016-03-20 14:07 Parth Sane
0 siblings, 0 replies; 6+ messages in thread
From: Parth Sane @ 2016-03-20 14:07 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, florian.c.schilhabel, bhaktipriya96, luisbg, devel,
linux-kernel, punitvara, stillcompiling, Parth Sane
Removed checkpatch warning caused due to FSF address paragraph
Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
---
drivers/staging/rtl8712/ieee80211.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
index d13b4d5..8918654 100644
--- a/drivers/staging/rtl8712/ieee80211.c
+++ b/drivers/staging/rtl8712/ieee80211.c
@@ -13,10 +13,6 @@
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
* Modifications for inclusion into the Linux staging tree are
* Copyright(c) 2010 Larry Finger. All rights reserved.
*
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: rtl8712: Removed FSF address warning
@ 2016-03-20 13:59 Parth Sane
2016-03-20 14:26 ` Larry Finger
0 siblings, 1 reply; 6+ messages in thread
From: Parth Sane @ 2016-03-20 13:59 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, florian.c.schilhabel, amitoj1606, luisbg, devel,
linux-kernel, Parth Sane
Removed checkpatch warning caused by FSF address block
Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
---
drivers/staging/rtl8712/hal_init.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c
index 8008efe..225ef37 100644
--- a/drivers/staging/rtl8712/hal_init.c
+++ b/drivers/staging/rtl8712/hal_init.c
@@ -13,10 +13,6 @@
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
* Modifications for inclusion into the Linux staging tree are
* Copyright(c) 2010 Larry Finger. All rights reserved.
*
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8712: Removed FSF address warning
2016-03-20 13:59 Parth Sane
@ 2016-03-20 14:26 ` Larry Finger
2016-03-20 14:58 ` Parth Sane
0 siblings, 1 reply; 6+ messages in thread
From: Larry Finger @ 2016-03-20 14:26 UTC (permalink / raw)
To: Parth Sane, gregkh
Cc: florian.c.schilhabel, amitoj1606, luisbg, devel, linux-kernel
On 03/20/2016 08:59 AM, Parth Sane wrote:
> Removed checkpatch warning caused by FSF address block
> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
> ---
> drivers/staging/rtl8712/hal_init.c | 4 ----
> 1 file changed, 4 deletions(-)
Now you have at least 3 different patches all with the same subject! How is the
maintainer supposed to keep them separate? Patchworks will replace each of them
with the next one having the same title.
A better way would be to create a multiple-part set of patches with the subject
containing the name of the file being "fixed".
Note that this warning was added to checkpatch.pl well after the driver was
added to the staging tree. In fact, if this warning had been present then, the
FSF address would have been removed.
I consider this type of patch to be of minimal value; however, if you do not
remove this warning, then someone else will. Thus, you should repackage these
changes. By my count, there are 94 files containing this information. Dropping
them as one set of patches might be too many at once. I would split them into
groups of 13 files in one batch, 14 in the next, then 15, 16, 17, and finally
19, then each group will also be distinguishable.
If GregKH wants it done differently, he will let us know.
Larry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8712: Removed FSF address warning
2016-03-20 14:26 ` Larry Finger
@ 2016-03-20 14:58 ` Parth Sane
0 siblings, 0 replies; 6+ messages in thread
From: Parth Sane @ 2016-03-20 14:58 UTC (permalink / raw)
To: Larry Finger
Cc: gregkh, florian.c.schilhabel, amitoj1606, luisbg, devel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]
> On 20-Mar-2016, at 7:56 PM, Larry Finger <larry.finger@lwfinger.net> wrote:
>
> On 03/20/2016 08:59 AM, Parth Sane wrote:
>> Removed checkpatch warning caused by FSF address block
>> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
>> ---
>> drivers/staging/rtl8712/hal_init.c | 4 ----
>> 1 file changed, 4 deletions(-)
>
> Now you have at least 3 different patches all with the same subject! How is the maintainer supposed to keep them separate? Patchworks will replace each of them with the next one having the same title.
>
> A better way would be to create a multiple-part set of patches with the subject containing the name of the file being "fixed".
>
> Note that this warning was added to checkpatch.pl well after the driver was added to the staging tree. In fact, if this warning had been present then, the FSF address would have been removed.
>
> I consider this type of patch to be of minimal value; however, if you do not remove this warning, then someone else will. Thus, you should repackage these changes. By my count, there are 94 files containing this information. Dropping them as one set of patches might be too many at once. I would split them into groups of 13 files in one batch, 14 in the next, then 15, 16, 17, and finally 19, then each group will also be distinguishable.
>
> If GregKH wants it done differently, he will let us know.
>
> Larry
>
Hi,
It has been pointed out to me that I should send patch sets. I will be doing so. So please ignore the earlier sent patches except the parenthesis patch.
Its been a pleasure to work with such a helpful community and hope to do do more in the future.
Regards,
Parth Sane
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 842 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: rtl8712: Removed FSF address warning
@ 2016-03-20 13:42 Parth Sane
0 siblings, 0 replies; 6+ messages in thread
From: Parth Sane @ 2016-03-20 13:42 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, florian.c.schilhabel, devel, linux-kernel,
Parth Sane
Removed checkpatch warning caused by FSF address paragraph.
Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
---
drivers/staging/rtl8712/ethernet.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/ethernet.h b/drivers/staging/rtl8712/ethernet.h
index fad173f..039da36 100644
--- a/drivers/staging/rtl8712/ethernet.h
+++ b/drivers/staging/rtl8712/ethernet.h
@@ -11,10 +11,6 @@
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
* Modifications for inclusion into the Linux staging tree are
* Copyright(c) 2010 Larry Finger. All rights reserved.
*
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-20 14:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-20 14:13 [PATCH] staging: rtl8712: Removed FSF address warning Parth Sane
-- strict thread matches above, loose matches on Subject: below --
2016-03-20 14:07 Parth Sane
2016-03-20 13:59 Parth Sane
2016-03-20 14:26 ` Larry Finger
2016-03-20 14:58 ` Parth Sane
2016-03-20 13:42 Parth Sane
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox