From: Joe Perches <joe@perches.com>
To: Colin King <colin.king@canonical.com>,
Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, Dan Carpenter <error27@gmail.com>,
Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH] gma500: fix missing comma in dsi_errors array initializer
Date: Tue, 22 Mar 2016 16:40:18 -0700 [thread overview]
Message-ID: <1458690018.22080.5.camel@perches.com> (raw)
In-Reply-To: <1458686973-13686-1-git-send-email-colin.king@canonical.com>
On Tue, 2016-03-22 at 22:49 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a missing comma between two strings in the dsi_errors[]
> array initializer, causing two strings to be concatenated and the
> array being incorrectly initialized. Add in the missing comma.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> index 6b43ae3..1616af2 100644
> --- a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> +++ b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> @@ -72,7 +72,7 @@ static const char *const dsi_errors[] = {
> "RX Prot Violation",
> "HS Generic Write FIFO Full",
> "LP Generic Write FIFO Full",
> - "Generic Read Data Avail"
> + "Generic Read Data Avail",
> "Special Packet Sent",
> "Tearing Effect",
> };
>From 2011:
https://lkml.org/lkml/2011/7/8/197
and
commit fc5ace7ed2a58e32047abf65ff8b5a6432e92fac
Author: Dan Carpenter <error27@gmail.com>
Date: Fri Jul 8 09:45:19 2011 +0100
Staging: gma500: typo in array initialization
There is a comma missing here between the strings so they were
concatenated by mistake.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Apparently this wasn't merged back into this version.
Are there any other changes in that old staging version that
also need to be merged back?
next prev parent reply other threads:[~2016-03-22 23:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 22:49 [PATCH] gma500: fix missing comma in dsi_errors array initializer Colin King
2016-03-22 23:40 ` Joe Perches [this message]
2016-03-23 1:28 ` One Thousand Gnomes
2016-04-02 12:49 ` Patrik Jakobsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458690018.22080.5.camel@perches.com \
--to=joe@perches.com \
--cc=airlied@linux.ie \
--cc=alan@linux.intel.com \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox