From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756404AbcCWUY7 (ORCPT ); Wed, 23 Mar 2016 16:24:59 -0400 Received: from mga03.intel.com ([134.134.136.65]:7420 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752022AbcCWUY6 (ORCPT ); Wed, 23 Mar 2016 16:24:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,383,1455004800"; d="scan'208";a="943665642" Message-ID: <1458764521.27934.168.camel@linux.intel.com> Subject: Re: [PATCH v6] acpi: Issue _OSC call for native thermal interrupt handling From: Srinivas Pandruvada To: Linda Knippers , rjw@rjwysocki.net Cc: tony.luck@intel.com, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, lenb@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Date: Wed, 23 Mar 2016 13:22:01 -0700 In-Reply-To: <56F2C7B5.4000208@hpe.com> References: <1458706064-4147-1-git-send-email-srinivas.pandruvada@linux.intel.com> <56F2C7B5.4000208@hpe.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3 (3.18.3-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-03-23 at 12:43 -0400, Linda Knippers wrote: > I raised a general concern on a previous patch so I found a 1P server > with Skylake and HWP to try.  This doesn't qualify as a tested-by > since all I did was apply the patch and boot the server but hey, it > booted. Thanks. > > I do have a question below... > [...] > + if (ACPI_SUCCESS(acpi_run_osc(handle, &osc_context))) { > > + acpi_hwp_native_thermal_lvt_set = true; > > + kfree(osc_context.ret.pointer); > > There are other boot messages that indicate when something is > happening > with _OSC.  Should there be one for this?  Or is there some other > obvious > way one can know that this was set? > I am following model of acpi_bus_osc_support, which issues _OSC for global platform scope, where nothing is getting printed. If it is useful, I don't mind adding a print. Rafael, What do you think? Thanks, Srinivas