From: Joe Perches <joe@perches.com>
To: Bhaskar Jupudi <njupudi@ucsc.edu>,
davem@davemloft.net, igal.liberman@freescale.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers : Remove unnecessary void pointer conversions
Date: Sat, 26 Mar 2016 22:49:05 -0700 [thread overview]
Message-ID: <1459057745.23450.17.camel@perches.com> (raw)
In-Reply-To: <1459050140-14621-1-git-send-email-njupudi@ucsc.edu>
On Sat, 2016-03-26 at 20:42 -0700, Bhaskar Jupudi wrote:
> Explicit void pointer conversion is unnecessary
> because the conversions to and from a void pointer
> are always implicit in 'C'. Changed two instances
> of such conversions.
Your patch subject is incorrect, this is for fman
not all of drivers/
If you do one file, you should do them all.
$ git grep -E "\*\s*\)\s*of_get_property" drivers/net/ethernet/freescale/
drivers/net/ethernet/freescale/fman/fman.c: u32_prop = (const u32 *)of_get_property(fm_node, "cell-index", &lenp);
drivers/net/ethernet/freescale/fman/fman.c: u32_prop = (const u32 *)of_get_property(fm_node,
drivers/net/ethernet/freescale/fman/fman_port.c: u32_prop = (const u32 *)of_get_property(port_node, "cell-index", &lenp);
drivers/net/ethernet/freescale/fman/fman_port.c: u32_prop = (const u32 *)of_get_property(port_node,
drivers/net/ethernet/freescale/fman/fman_port.c: u32_prop = (const u32 *)of_get_property(port_node,
drivers/net/ethernet/freescale/fman/mac.c: char_prop = (const char *)of_get_property(mac_node,
> drivers/net/ethernet/freescale/fman/fman.c | 4 ++--
next prev parent reply other threads:[~2016-03-27 5:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 3:42 [PATCH] drivers : Remove unnecessary void pointer conversions Bhaskar Jupudi
2016-03-27 5:49 ` Joe Perches [this message]
2016-03-27 11:46 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459057745.23450.17.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=igal.liberman@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=njupudi@ucsc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox