From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754142AbcC0FtN (ORCPT ); Sun, 27 Mar 2016 01:49:13 -0400 Received: from smtprelay0253.hostedemail.com ([216.40.44.253]:43300 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752035AbcC0FtJ (ORCPT ); Sun, 27 Mar 2016 01:49:09 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3873:4321:4385:5007:10004:10400:10848:11026:11232:11658:11783:11914:12043:12048:12517:12519:12740:13069:13163:13229:13311:13357:13439:13894:14659:14721:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: wash77_6c9f6daabe658 X-Filterd-Recvd-Size: 2034 Message-ID: <1459057745.23450.17.camel@perches.com> Subject: Re: [PATCH] drivers : Remove unnecessary void pointer conversions From: Joe Perches To: Bhaskar Jupudi , davem@davemloft.net, igal.liberman@freescale.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 26 Mar 2016 22:49:05 -0700 In-Reply-To: <1459050140-14621-1-git-send-email-njupudi@ucsc.edu> References: <1459050140-14621-1-git-send-email-njupudi@ucsc.edu> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-03-26 at 20:42 -0700, Bhaskar Jupudi wrote: > Explicit void pointer conversion is unnecessary > because the conversions to and from a void pointer > are always implicit in 'C'. Changed two instances  > of such conversions. Your patch subject is incorrect, this is for fman not all of drivers/ If you do one file, you should do them all. $ git grep -E "\*\s*\)\s*of_get_property" drivers/net/ethernet/freescale/ drivers/net/ethernet/freescale/fman/fman.c:     u32_prop = (const u32 *)of_get_property(fm_node, "cell-index", &lenp); drivers/net/ethernet/freescale/fman/fman.c:     u32_prop = (const u32 *)of_get_property(fm_node, drivers/net/ethernet/freescale/fman/fman_port.c:        u32_prop = (const u32 *)of_get_property(port_node, "cell-index", &lenp); drivers/net/ethernet/freescale/fman/fman_port.c:                u32_prop = (const u32 *)of_get_property(port_node, drivers/net/ethernet/freescale/fman/fman_port.c:                u32_prop = (const u32 *)of_get_property(port_node, drivers/net/ethernet/freescale/fman/mac.c:      char_prop = (const char *)of_get_property(mac_node, >  drivers/net/ethernet/freescale/fman/fman.c | 4 ++--