public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Ray Jui <rjui@broadcom.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	<bcm-kernel-feedback-list@broadcom.com>,
	<linux-gpio@vger.kernel.org>
Subject: [PATCH 1/9] drivers/gpio: make gpio-bcm-kona.c explicitly non-modular
Date: Sun, 27 Mar 2016 11:44:41 -0400	[thread overview]
Message-ID: <1459093489-18314-2-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1459093489-18314-1-git-send-email-paul.gortmaker@windriver.com>

The Kconfig currently controlling compilation of this code is:

config GPIO_BCM_KONA
        bool "Broadcom Kona GPIO"

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modularity so that when reading the
driver there is no doubt it is builtin-only.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.

Cc: Ray Jui <rjui@broadcom.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/gpio/gpio-bcm-kona.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
index 2fd38d598f3d..9aabc48ff5de 100644
--- a/drivers/gpio/gpio-bcm-kona.c
+++ b/drivers/gpio/gpio-bcm-kona.c
@@ -1,4 +1,7 @@
 /*
+ * Broadcom Kona GPIO Driver
+ *
+ * Author: Broadcom Corporation <bcm-kernel-feedback-list@broadcom.com>
  * Copyright (C) 2012-2014 Broadcom Corporation
  *
  * This program is free software; you can redistribute it and/or
@@ -17,7 +20,7 @@
 #include <linux/gpio.h>
 #include <linux/of_device.h>
 #include <linux/of_irq.h>
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/irqdomain.h>
 #include <linux/irqchip/chained_irq.h>
 
@@ -502,8 +505,6 @@ static struct of_device_id const bcm_kona_gpio_of_match[] = {
 	{}
 };
 
-MODULE_DEVICE_TABLE(of, bcm_kona_gpio_of_match);
-
 /*
  * This lock class tells lockdep that GPIO irqs are in a different
  * category than their parents, so it won't report false recursion.
@@ -659,9 +660,4 @@ static struct platform_driver bcm_kona_gpio_driver = {
 	},
 	.probe = bcm_kona_gpio_probe,
 };
-
-module_platform_driver(bcm_kona_gpio_driver);
-
-MODULE_AUTHOR("Broadcom Corporation <bcm-kernel-feedback-list@broadcom.com>");
-MODULE_DESCRIPTION("Broadcom Kona GPIO Driver");
-MODULE_LICENSE("GPL v2");
+builtin_platform_driver(bcm_kona_gpio_driver);
-- 
2.6.1

  reply	other threads:[~2016-03-27 15:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-27 15:44 [PATCH 0/9] gpio: batch #1: remove modular usage from non-modular drivers Paul Gortmaker
2016-03-27 15:44 ` Paul Gortmaker [this message]
2016-03-31 10:01   ` [PATCH 1/9] drivers/gpio: make gpio-bcm-kona.c explicitly non-modular Linus Walleij
2016-03-27 15:44 ` [PATCH 2/9] drivers/gpio: make gpio-mb86s7x.c driver " Paul Gortmaker
2016-03-31 13:01   ` Linus Walleij
2016-03-27 15:44 ` [PATCH 3/9] drivers/gpio: make gpio-mc9s08dz60.c " Paul Gortmaker
2016-03-31 13:02   ` Linus Walleij
2016-03-27 15:44 ` [PATCH 4/9] drivers/gpio: make gpio-moxart.c " Paul Gortmaker
2016-03-31 13:03   ` Linus Walleij
2016-03-27 15:44 ` [PATCH 5/9] drivers/gpio: make gpio-mvebu.c " Paul Gortmaker
2016-03-31 13:05   ` Linus Walleij
2016-03-27 15:44 ` [PATCH 6/9] drivers/gpio: make gpio-pl061.c " Paul Gortmaker
2016-03-27 17:40   ` Baruch Siach
2016-03-31 13:06   ` Linus Walleij
2016-03-27 15:44 ` [PATCH 7/9] drivers/gpio: make gpio-sta2x11.c " Paul Gortmaker
2016-03-31 13:08   ` Linus Walleij
2016-03-27 15:44 ` [PATCH 8/9] drivers/gpio: make gpio-xgene.c " Paul Gortmaker
2016-03-31 13:09   ` Linus Walleij
2016-03-27 15:44 ` [PATCH 9/9] drivers/gpio: make gpio-zx.c " Paul Gortmaker
2016-03-31 13:11   ` Linus Walleij
2016-03-31 13:12 ` [PATCH 0/9] gpio: batch #1: remove modular usage from non-modular drivers Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459093489-18314-2-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjui@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox