From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
<linux-gpio@vger.kernel.org>
Subject: [PATCH 2/9] drivers/gpio: make gpio-mb86s7x.c driver explicitly non-modular
Date: Sun, 27 Mar 2016 11:44:42 -0400 [thread overview]
Message-ID: <1459093489-18314-3-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1459093489-18314-1-git-send-email-paul.gortmaker@windriver.com>
The Kconfig for this driver is currently:
config GPIO_MB86S7X
bool "GPIO support for Fujitsu MB86S7x Platforms"
...meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modularity, so that when reading the
driver there is no doubt it is builtin-only.
Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.
We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/gpio/gpio-mb86s7x.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpio/gpio-mb86s7x.c b/drivers/gpio/gpio-mb86s7x.c
index 7fffc1d6c055..d69bd24b241c 100644
--- a/drivers/gpio/gpio-mb86s7x.c
+++ b/drivers/gpio/gpio-mb86s7x.c
@@ -17,7 +17,6 @@
#include <linux/io.h>
#include <linux/init.h>
#include <linux/clk.h>
-#include <linux/module.h>
#include <linux/err.h>
#include <linux/errno.h>
#include <linux/ioport.h>
@@ -210,7 +209,6 @@ static const struct of_device_id mb86s70_gpio_dt_ids[] = {
{ .compatible = "fujitsu,mb86s70-gpio" },
{ /* sentinel */ }
};
-MODULE_DEVICE_TABLE(of, mb86s70_gpio_dt_ids);
static struct platform_driver mb86s70_gpio_driver = {
.driver = {
@@ -225,8 +223,4 @@ static int __init mb86s70_gpio_init(void)
{
return platform_driver_register(&mb86s70_gpio_driver);
}
-module_init(mb86s70_gpio_init);
-
-MODULE_DESCRIPTION("MB86S7x GPIO Driver");
-MODULE_ALIAS("platform:mb86s70-gpio");
-MODULE_LICENSE("GPL");
+device_initcall(mb86s70_gpio_init);
--
2.6.1
next prev parent reply other threads:[~2016-03-27 15:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 15:44 [PATCH 0/9] gpio: batch #1: remove modular usage from non-modular drivers Paul Gortmaker
2016-03-27 15:44 ` [PATCH 1/9] drivers/gpio: make gpio-bcm-kona.c explicitly non-modular Paul Gortmaker
2016-03-31 10:01 ` Linus Walleij
2016-03-27 15:44 ` Paul Gortmaker [this message]
2016-03-31 13:01 ` [PATCH 2/9] drivers/gpio: make gpio-mb86s7x.c driver " Linus Walleij
2016-03-27 15:44 ` [PATCH 3/9] drivers/gpio: make gpio-mc9s08dz60.c " Paul Gortmaker
2016-03-31 13:02 ` Linus Walleij
2016-03-27 15:44 ` [PATCH 4/9] drivers/gpio: make gpio-moxart.c " Paul Gortmaker
2016-03-31 13:03 ` Linus Walleij
2016-03-27 15:44 ` [PATCH 5/9] drivers/gpio: make gpio-mvebu.c " Paul Gortmaker
2016-03-31 13:05 ` Linus Walleij
2016-03-27 15:44 ` [PATCH 6/9] drivers/gpio: make gpio-pl061.c " Paul Gortmaker
2016-03-27 17:40 ` Baruch Siach
2016-03-31 13:06 ` Linus Walleij
2016-03-27 15:44 ` [PATCH 7/9] drivers/gpio: make gpio-sta2x11.c " Paul Gortmaker
2016-03-31 13:08 ` Linus Walleij
2016-03-27 15:44 ` [PATCH 8/9] drivers/gpio: make gpio-xgene.c " Paul Gortmaker
2016-03-31 13:09 ` Linus Walleij
2016-03-27 15:44 ` [PATCH 9/9] drivers/gpio: make gpio-zx.c " Paul Gortmaker
2016-03-31 13:11 ` Linus Walleij
2016-03-31 13:12 ` [PATCH 0/9] gpio: batch #1: remove modular usage from non-modular drivers Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459093489-18314-3-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox