From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Feng Kan <fkan@apm.com>, Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
<linux-gpio@vger.kernel.org>
Subject: [PATCH 8/9] drivers/gpio: make gpio-xgene.c explicitly non-modular
Date: Sun, 27 Mar 2016 11:44:48 -0400 [thread overview]
Message-ID: <1459093489-18314-9-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1459093489-18314-1-git-send-email-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
drivers/gpio/Kconfig:config GPIO_XGENE
drivers/gpio/Kconfig: bool "APM X-Gene GPIO controller support"
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.
Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.
Cc: Feng Kan <fkan@apm.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/gpio/gpio-xgene.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/gpio/gpio-xgene.c b/drivers/gpio/gpio-xgene.c
index c0aa387664bf..4193502fe3be 100644
--- a/drivers/gpio/gpio-xgene.c
+++ b/drivers/gpio/gpio-xgene.c
@@ -17,7 +17,6 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
-#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/io.h>
@@ -211,7 +210,6 @@ static const struct of_device_id xgene_gpio_of_match[] = {
{ .compatible = "apm,xgene-gpio", },
{},
};
-MODULE_DEVICE_TABLE(of, xgene_gpio_of_match);
static struct platform_driver xgene_gpio_driver = {
.driver = {
@@ -221,9 +219,4 @@ static struct platform_driver xgene_gpio_driver = {
},
.probe = xgene_gpio_probe,
};
-
-module_platform_driver(xgene_gpio_driver);
-
-MODULE_AUTHOR("Feng Kan <fkan@apm.com>");
-MODULE_DESCRIPTION("APM X-Gene GPIO driver");
-MODULE_LICENSE("GPL");
+builtin_platform_driver(xgene_gpio_driver);
--
2.6.1
next prev parent reply other threads:[~2016-03-27 15:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 15:44 [PATCH 0/9] gpio: batch #1: remove modular usage from non-modular drivers Paul Gortmaker
2016-03-27 15:44 ` [PATCH 1/9] drivers/gpio: make gpio-bcm-kona.c explicitly non-modular Paul Gortmaker
2016-03-31 10:01 ` Linus Walleij
2016-03-27 15:44 ` [PATCH 2/9] drivers/gpio: make gpio-mb86s7x.c driver " Paul Gortmaker
2016-03-31 13:01 ` Linus Walleij
2016-03-27 15:44 ` [PATCH 3/9] drivers/gpio: make gpio-mc9s08dz60.c " Paul Gortmaker
2016-03-31 13:02 ` Linus Walleij
2016-03-27 15:44 ` [PATCH 4/9] drivers/gpio: make gpio-moxart.c " Paul Gortmaker
2016-03-31 13:03 ` Linus Walleij
2016-03-27 15:44 ` [PATCH 5/9] drivers/gpio: make gpio-mvebu.c " Paul Gortmaker
2016-03-31 13:05 ` Linus Walleij
2016-03-27 15:44 ` [PATCH 6/9] drivers/gpio: make gpio-pl061.c " Paul Gortmaker
2016-03-27 17:40 ` Baruch Siach
2016-03-31 13:06 ` Linus Walleij
2016-03-27 15:44 ` [PATCH 7/9] drivers/gpio: make gpio-sta2x11.c " Paul Gortmaker
2016-03-31 13:08 ` Linus Walleij
2016-03-27 15:44 ` Paul Gortmaker [this message]
2016-03-31 13:09 ` [PATCH 8/9] drivers/gpio: make gpio-xgene.c " Linus Walleij
2016-03-27 15:44 ` [PATCH 9/9] drivers/gpio: make gpio-zx.c " Paul Gortmaker
2016-03-31 13:11 ` Linus Walleij
2016-03-31 13:12 ` [PATCH 0/9] gpio: batch #1: remove modular usage from non-modular drivers Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459093489-18314-9-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=fkan@apm.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox