From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753274AbcC0TWM (ORCPT ); Sun, 27 Mar 2016 15:22:12 -0400 Received: from smtprelay0063.hostedemail.com ([216.40.44.63]:34189 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753123AbcC0TWI (ORCPT ); Sun, 27 Mar 2016 15:22:08 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:560:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:4321:5007:7514:8957:10004:10400:10848:11232:11658:11914:12043:12438:12517:12519:12555:12740:13069:13311:13357:13439:13894:14181:14659:14721:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: knot23_4c7b49314655c X-Filterd-Recvd-Size: 2119 Message-ID: <1459106524.25110.12.camel@perches.com> Subject: Re: [PATCH 4/5] staging: xgifb: fix comparison order From: Joe Perches To: Clifton Barnes , arnaud.patard@rtp-net.org Cc: kernel-janitors@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Date: Sun, 27 Mar 2016 12:22:04 -0700 In-Reply-To: <1459105983-17251-4-git-send-email-clifton.a.barnes@gmail.com> References: <1459105983-17251-1-git-send-email-clifton.a.barnes@gmail.com> <1459105983-17251-4-git-send-email-clifton.a.barnes@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-03-27 at 15:13 -0400, Clifton Barnes wrote: > fix checkpatch.pl warning about 'Comparisons should place the constant > on the right side of the test' checkpatch false positives. > Signed-off-by: Clifton Barnes > --- >  drivers/staging/xgifb/vb_setmode.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c > index 50c8ea4..8bf253c 100644 > --- a/drivers/staging/xgifb/vb_setmode.c > +++ b/drivers/staging/xgifb/vb_setmode.c > @@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table, >   if (pVBInfo->LCDInfo & EnableScalingLCD) >   tempdx &= (~PanelResInfo); >   > - if (table[i].PANELID == tempdx) { > + if (tempdx == table[i].PANELID) { >   tempbx = table[i].MASK; >   tempdx = pVBInfo->LCDInfo; >   > @@ -3902,7 +3902,7 @@ static struct XGI301C_Tap4TimingStruct const >   >   i = 0; >   while (Tap4TimingPtr[i].DE != 0xFFFF) { > - if (Tap4TimingPtr[i].DE == tempax) > + if (tempax == Tap4TimingPtr[i].DE) >   break; >   i++; >   }