public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: "Moore, Robert" <robert.moore@intel.com>,
	"Zheng, Lv" <lv.zheng@intel.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
	Len Brown <lenb@kernel.org>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"devel@acpica.org" <devel@acpica.org>
Subject: Re: [RFC PATCH] acpi: Use a more normal logging style for ACPI_<LEVEL> calls
Date: Tue, 29 Mar 2016 09:12:09 -0700	[thread overview]
Message-ID: <1459267929.25110.80.camel@perches.com> (raw)
In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37E4553F8@ORSMSX110.amr.corp.intel.com>

On Tue, 2016-03-29 at 15:34 +0000, Moore, Robert wrote:
> On the other hand, we removed AE_INFO from ACPI_INFO a while back, and
> this may remove the necessity for the double parens.

Does remove the necessity.

I suppose I could look through the ACPICA sources and generate
the same patch in the ACPICA style.

I didn't manage to run the script that does the style
conversion though.

$ git clone git://github.com/acpica/acpica.git
$ cd acpica
$ make
$

now what?

Removing AE_INFO from ACPI_(WARNING|ERROR) (it seems there
are only a few uses without it and those uses seem
equivalent) is doable too.

For instance:

$ git grep -w ACPI_ERROR|grep -v AE_INFO
[]
source/components/utilities/utobject.c:        ACPI_ERROR ((ModuleName, LineNumber,
source/components/utilities/uttrack.c:        ACPI_ERROR ((Module, Line,
source/components/utilities/uttrack.c:        ACPI_ERROR ((Module, Line,
source/components/utilities/uttrack.c:        ACPI_ERROR ((Module, Line,

  reply	other threads:[~2016-03-29 16:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29  3:30 [RFC PATCH] acpi: Use a more normal logging style for ACPI_<LEVEL> calls Joe Perches
2016-03-29 15:27 ` Moore, Robert
2016-03-29 15:34   ` Moore, Robert
2016-03-29 16:12     ` Joe Perches [this message]
2016-03-29 16:56     ` Joe Perches
2016-03-29 17:50       ` Moore, Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459267929.25110.80.camel@perches.com \
    --to=joe@perches.com \
    --cc=devel@acpica.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lv.zheng@intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox