From: Dominique van den Broeck <domdevlin@free.fr>
To: Joe Perches <joe@perches.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Hurley <peter@hurleysoftware.com>,
Shraddha Barke <shraddha.6596@gmail.com>,
Radek Dostal <rd@radekdostal.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call to a long function
Date: Tue, 29 Mar 2016 19:50:26 +0200 [thread overview]
Message-ID: <1459273826.2630.10.camel@free.fr> (raw)
In-Reply-To: <1459273107.25110.91.camel@perches.com>
> Does this really look better to you?
>
> Long identifiers like "wait_event_interruptible_timeout"
> (32 chars) make
> using 80 columns a bit silly.
>
> Please remember checkpatch is a stupid script and that
> not every warning it emits is dicta.
Actually, not much and as a matter of fact, I hesitated before sending
this particular patch. That's also why I submitted it as the last one
of them all and why it fixes only a single row : so we can eventually
reject it easily.
I'm not a checkpatch.pl nazi neither and anyway, even the "Development
Process" document specify that it's not to be considered as a strict
rule if it makes the things worse.
But I found it useful anyway because this set brings back all the
warnings to only two categories (comments over spinlocks and memory
barriers) and also because this kind of minor corrections could still
be appreciated by people that have better things to do... :-)
Cheers.
next prev parent reply other threads:[~2016-03-29 17:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 17:14 [PATCH 1/3] staging: fwserial: (coding style) Turning every "unsigned" into "unsigned int" Dominique van den Broeck
2016-03-29 17:14 ` [PATCH 2/3] staging: fwserial: (coding style) removing "!= NULL" to comply with checkpatch.pl Dominique van den Broeck
2016-04-01 16:25 ` Peter Hurley
2016-03-29 17:14 ` [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call to a long function Dominique van den Broeck
2016-03-29 17:38 ` Joe Perches
2016-03-29 17:50 ` Dominique van den Broeck [this message]
2016-04-01 16:38 ` Peter Hurley
2016-04-01 23:20 ` Dominique van den Broeck
2016-04-01 23:29 ` Peter Hurley
2016-04-01 16:22 ` [PATCH 1/3] staging: fwserial: (coding style) Turning every "unsigned" into "unsigned int" Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459273826.2630.10.camel@free.fr \
--to=domdevlin@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=rd@radekdostal.com \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox