From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbcC3Ku1 (ORCPT ); Wed, 30 Mar 2016 06:50:27 -0400 Received: from mga04.intel.com ([192.55.52.120]:2722 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbcC3Ku0 (ORCPT ); Wed, 30 Mar 2016 06:50:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,415,1455004800"; d="scan'208";a="947937397" Message-ID: <1459335073.5907.34.camel@linux.intel.com> Subject: Re: [PATCH net-next] net: hns: add support of pause frame ctrl for HNS V2 From: Andy Shevchenko To: Yisen Zhuang , davem@davemloft.net, salil.mehta@huawei.com, liguozhu@huawei.com, huangdaode@hisilicon.com, arnd@arndb.de, andrew@lunn.ch, geliangtang@163.com, ivecera@redhat.com, lisheng011@huawei.com, fengguang.wu@intel.com Cc: charles.chenxin@huawei.com, haifeng.wei@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com Date: Wed, 30 Mar 2016 13:51:13 +0300 In-Reply-To: <1459235041-91766-1-git-send-email-Yisen.Zhuang@huawei.com> References: <1459235041-91766-1-git-send-email-Yisen.Zhuang@huawei.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-03-29 at 15:04 +0800, Yisen Zhuang wrote: > From: Lisheng > > The patch adds support of pause ctrl for HNS V2, and this feature is > lost > by HNS V1: >        1) service ports can disable rx pause frame, >        2) debug ports can open tx/rx pause frame. > > And this patch updates the REGs about the pause ctrl when updated > status function called by upper layer routine. > --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c > +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c > > +void hns_dsaf_get_rx_mac_pause_en(struct dsaf_device *dsaf_dev, int > mac_id, > +   u32 *en) > +{ > + if (AE_IS_VER1(dsaf_dev->dsaf_ver)) > + *en = 1; >   else >   dsaf_write_dev(dsaf_dev, DSAF_PFC_EN_0_REG + mac_id > * 4, 0xff); > + *en = dsaf_get_dev_bit(dsaf_dev, > +        DSAF_PAUSE_CFG_REG + mac_id * > 4, > +        DSAF_MAC_PAUSE_RX_EN_B); And what the point of if branch then? I think it's an obvious misfix, you must replace else to } else { and add }. How did you test this part? >  } -- Andy Shevchenko Intel Finland Oy