public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Johannes Thumshirn <jthumshirn@suse.de>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: "Ewan D. Milne" <emilne@redhat.com>,
	Hannes Reinecke <hare@suse.de>,
	Christoph Hellwig <hch@infradead.org>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2 0/2] Update SCSI target removal path
Date: Wed, 30 Mar 2016 09:43:28 -0700	[thread overview]
Message-ID: <1459356208.2509.9.camel@HansenPartnership.com> (raw)
In-Reply-To: <cover.1459249252.git.jthumshirn@suse.de>

On Wed, 2016-03-30 at 09:09 +0200, Johannes Thumshirn wrote:
> [resend with linux-scsi@ in Cc, my apologies]
> 
> This is a follow up to "scsi: Add intermediate STARGET_REMOVE state 
> to scsi_target_state".
> 
> If anyone has an idea how to create a regression test suite for the 
> target removal path I'd be all ears, given the fact that this is the 
> 3rd or 4th patch targeting it.

Actually, could you reverse the order of these patches, please.  It's
not safe to revert the soft lockup fix until after the intermediate
state is introduced.  I'd rather we didn't go through a point in the
tree where the bug exists again.

Thanks,

James

  parent reply	other threads:[~2016-03-30 16:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30  7:09 [RESEND PATCH v2 0/2] Update SCSI target removal path Johannes Thumshirn
2016-03-30  7:09 ` [RESEND PATCH v2 1/2] Revert "scsi: fix soft lockup in scsi_remove_target() on module removal" Johannes Thumshirn
2016-03-30 16:23   ` Ewan D. Milne
2016-03-30  7:09 ` [RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state Johannes Thumshirn
2016-03-30 16:25   ` Ewan D. Milne
2016-03-30 16:43 ` James Bottomley [this message]
2016-03-31  6:58   ` [RESEND PATCH v2 0/2] Update SCSI target removal path jthumshirn
     [not found] ` <108843b606da2c793bd830af42d5907bf8776d13.1459249252.git.jthumshirn__45300.0338202857$1459322118$gmane$org@suse.de>
2016-03-30 21:44   ` [RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state Sebastian Herbszt
2016-03-31  7:24     ` jthumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459356208.2509.9.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=emilne@redhat.com \
    --cc=hare@suse.de \
    --cc=hch@infradead.org \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox