From: Joe Perches <joe@perches.com>
To: Daniel Bristot de Oliveira <bristot@redhat.com>,
"Moore, Robert" <robert.moore@intel.com>,
"Zheng, Lv" <lv.zheng@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"devel@acpica.org" <devel@acpica.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI_INFO boot message
Date: Wed, 30 Mar 2016 21:27:07 -0700 [thread overview]
Message-ID: <1459398427.1744.2.camel@perches.com> (raw)
In-Reply-To: <56FC7941.2080202@redhat.com>
On Wed, 2016-03-30 at 22:11 -0300, Daniel Bristot de Oliveira wrote:
> On 03/29/2016 04:09 PM, Moore, Robert wrote:
> > Actually, I did in fact put that there to break up the output after the tables are loaded. Is this a problem?
> Well, I do not believe that there is a real problem on it.
>
> On the other hand, it does not seem to be common to have blank lines in
> the kernel log, and as there is no info about from where the black line
> comes from, it does not even seems to be connected to the previous
> message. So although my patch is about "cosmetics", IMHO it is worth as
> pattern or best practices.
FWIW: I agree with Daniel.
prev parent reply other threads:[~2016-03-31 4:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 17:59 [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI_INFO boot message Daniel Bristot de Oliveira
2016-03-29 19:09 ` Moore, Robert
2016-03-31 1:11 ` Daniel Bristot de Oliveira
2016-03-31 4:27 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459398427.1744.2.camel@perches.com \
--to=joe@perches.com \
--cc=bristot@redhat.com \
--cc=devel@acpica.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox