From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753155AbcDCVYy (ORCPT ); Sun, 3 Apr 2016 17:24:54 -0400 Received: from mail5.windriver.com ([192.103.53.11]:54006 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752954AbcDCVYu (ORCPT ); Sun, 3 Apr 2016 17:24:50 -0400 From: Paul Gortmaker To: CC: Paul Gortmaker , Chanwoo Choi , Krzysztof Kozlowski , Samuel Ortiz , Lee Jones Subject: [PATCH 4/7] drivers/mfd: make max14577.c explicitly non-modular Date: Sun, 3 Apr 2016 17:24:16 -0400 Message-ID: <1459718659-28316-5-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1459718659-28316-1-git-send-email-paul.gortmaker@windriver.com> References: <1459718659-28316-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Kconfig currently controlling compilation of this code is: mfd/Kconfig:config MFD_MAX14577 mfd/Kconfig: bool "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. Since module_init was not in use by this code, the init ordering remains unchanged with this commit. Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments. Cc: Chanwoo Choi Cc: Krzysztof Kozlowski Cc: Samuel Ortiz Cc: Lee Jones Signed-off-by: Paul Gortmaker --- drivers/mfd/max14577.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c index 2280b3fdcf68..9c0eb4efe246 100644 --- a/drivers/mfd/max14577.c +++ b/drivers/mfd/max14577.c @@ -19,7 +19,7 @@ */ #include -#include +#include #include #include #include @@ -490,7 +490,6 @@ static const struct i2c_device_id max14577_i2c_id[] = { { "max77836", MAXIM_DEVICE_TYPE_MAX77836, }, { } }; -MODULE_DEVICE_TABLE(i2c, max14577_i2c_id); #ifdef CONFIG_PM_SLEEP static int max14577_suspend(struct device *dev) @@ -562,13 +561,3 @@ static int __init max14577_i2c_init(void) return i2c_add_driver(&max14577_i2c_driver); } subsys_initcall(max14577_i2c_init); - -static void __exit max14577_i2c_exit(void) -{ - i2c_del_driver(&max14577_i2c_driver); -} -module_exit(max14577_i2c_exit); - -MODULE_AUTHOR("Chanwoo Choi , Krzysztof Kozlowski "); -MODULE_DESCRIPTION("Maxim 14577/77836 multi-function core driver"); -MODULE_LICENSE("GPL"); -- 2.8.0