From: Ming Lei <tom.leiming@gmail.com>
To: Jens Axboe <axboe@fb.com>, linux-kernel@vger.kernel.org
Cc: linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Boaz Harrosh <boaz@plexistor.com>,
Ming Lei <tom.leiming@gmail.com>, Joern Engel <joern@logfs.org>,
Prasad Joshi <prasadjoshi.linux@gmail.com>,
logfs@logfs.org (open list:LogFS)
Subject: [PATCH 25/27] fs: logfs: remove unnecesary check
Date: Tue, 5 Apr 2016 20:07:40 +0800 [thread overview]
Message-ID: <1459858062-21075-11-git-send-email-tom.leiming@gmail.com> (raw)
In-Reply-To: <1459858062-21075-1-git-send-email-tom.leiming@gmail.com>
The check on bio->bi_vcnt doesn't make sense in erase_end_io().
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
fs/logfs/dev_bdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/logfs/dev_bdev.c b/fs/logfs/dev_bdev.c
index db04231..3d9cde7 100644
--- a/fs/logfs/dev_bdev.c
+++ b/fs/logfs/dev_bdev.c
@@ -144,7 +144,6 @@ static void erase_end_io(struct bio *bio)
struct logfs_super *super = logfs_super(sb);
BUG_ON(bio->bi_error); /* FIXME: Retry io or write elsewhere */
- BUG_ON(bio->bi_vcnt == 0);
bio_put(bio);
if (atomic_dec_and_test(&super->s_pending_writes))
wake_up(&wq);
--
1.9.1
next prev parent reply other threads:[~2016-04-05 12:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 12:07 [PATCH 15/27] bcache: super: use bio_set_vec_table() Ming Lei
2016-04-05 12:07 ` [PATCH 16/27] bcache: super: use bio_get_base_vec Ming Lei
2016-04-05 12:07 ` [PATCH 17/27] dm: crypt: use bio_add_page() Ming Lei
2016-04-05 12:49 ` Christoph Hellwig
2016-04-05 12:07 ` [PATCH 18/27] dm: dm-io.c: use bio_get_base_vec() Ming Lei
2016-04-05 12:07 ` [PATCH 19/27] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments Ming Lei
2016-04-05 12:07 ` [PATCH 20/27] dm: dm-bufio.c: use bio_set_vec_table() Ming Lei
2016-04-05 13:04 ` Christoph Hellwig
2016-04-05 18:11 ` Mike Snitzer
2016-04-05 12:07 ` [PATCH 21/27] fs: logfs: " Ming Lei
2016-04-05 12:50 ` Christoph Hellwig
2016-04-05 12:07 ` [PATCH 22/27] fs: logfs: convert to bio_add_page() in sync_request() Ming Lei
2016-04-05 12:50 ` Christoph Hellwig
2016-04-05 12:07 ` [PATCH 23/27] fs: logfs: use bio_add_page() in __bdev_writeseg() Ming Lei
2016-04-05 12:07 ` [PATCH 24/27] fs: logfs: use bio_add_page() in do_erase() Ming Lei
2016-04-05 12:07 ` Ming Lei [this message]
2016-04-05 12:07 ` [PATCH 26/27] kernel/power/swap.c: use bio_get_base_vec() Ming Lei
2016-04-05 12:56 ` Christoph Hellwig
2016-04-05 13:19 ` Ming Lei
2016-04-05 12:07 ` [PATCH 27/27] mm: page_io.c: " Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459858062-21075-11-git-send-email-tom.leiming@gmail.com \
--to=tom.leiming@gmail.com \
--cc=axboe@fb.com \
--cc=boaz@plexistor.com \
--cc=hch@infradead.org \
--cc=joern@logfs.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logfs@logfs.org \
--cc=prasadjoshi.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox