From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934101AbcDFKH6 (ORCPT ); Wed, 6 Apr 2016 06:07:58 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:36379 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933798AbcDFKH5 (ORCPT ); Wed, 6 Apr 2016 06:07:57 -0400 From: Sudip Mukherjee To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] proc: fix dereference of ERR_PTR Date: Wed, 6 Apr 2016 11:07:45 +0100 Message-Id: <1459937265-4364-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On the unlikely event of a bad name, d_hash_and_lookup() can return the error value in ERR_PTR(). And we were only checking the return value of d_hash_and_lookup() to be NULL. In case it is not NULL and has some error then d_inode() will try to dereference it later. Signed-off-by: Sudip Mukherjee --- fs/proc/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index b1755b2..a71df53 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -1818,7 +1818,7 @@ bool proc_fill_cache(struct file *file, struct dir_context *ctx, ino_t ino; child = d_hash_and_lookup(dir, &qname); - if (!child) { + if (IS_ERR_OR_NULL(child)) { child = d_alloc(dir, &qname); if (!child) goto end_instantiate; -- 2.1.4