From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932187AbcDFLdX (ORCPT ); Wed, 6 Apr 2016 07:33:23 -0400 Received: from mga11.intel.com ([192.55.52.93]:14154 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751827AbcDFLdV (ORCPT ); Wed, 6 Apr 2016 07:33:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,447,1455004800"; d="scan'208";a="926601373" Message-ID: <1459942441.17884.77.camel@linux.intel.com> Subject: Re: [PATCH v3 06/10] sysctl: drop away useless label From: Andy Shevchenko To: Andrew Morton Cc: Dmitry Kasatkin , Mimi Zohar , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Rasmus Villemoes , linux-efi@vger.kernel.org, Matt Fleming , Arnd Bergmann , "Theodore Ts'o" Date: Wed, 06 Apr 2016 14:34:01 +0300 In-Reply-To: <20160405151752.de82f221f1c70ff901b2b958@linux-foundation.org> References: <1459864579-55988-1-git-send-email-andriy.shevchenko@linux.intel.com> <1459864579-55988-7-git-send-email-andriy.shevchenko@linux.intel.com> <20160405151752.de82f221f1c70ff901b2b958@linux-foundation.org> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-04-05 at 15:17 -0700, Andrew Morton wrote: > On Tue,  5 Apr 2016 16:56:15 +0300 Andy Shevchenko linux.intel.com> wrote: > > > > > We have no locking in bin_uuid(). Thus, we may remove the out label > > and use > > return statements directly. > > > Sure, but we may add locking or resource allocation in the future, in > which case this change will need to be undone.  I think it's better to > leave the code as-is.  It's presently quite typical kernel code. I have noticed you updated the patch already. I'm fine with either.  -- Andy Shevchenko Intel Finland Oy