From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753533AbcDFVKF (ORCPT ); Wed, 6 Apr 2016 17:10:05 -0400 Received: from mga04.intel.com ([192.55.52.120]:64609 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752906AbcDFVKC (ORCPT ); Wed, 6 Apr 2016 17:10:02 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,448,1455004800"; d="scan'208";a="949580507" From: "Koul, Vinod" To: "andy.shevchenko@gmail.com" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "vireshk@kernel.org" , "stable@vger.kernel.org" , "broonie@kernel.org" , "mark.rutland@arm.com" , "dmaengine@vger.kernel.org" , "gregkh@linuxfoundation.org" , "vgupta@synopsys.com" , "tj@kernel.org" , "andriy.shevchenko@linux.intel.com" , "egtvedt@samfundet.no" Subject: Re: [PATCH v3 01/15] dmaengine: dw: fix master selection Thread-Topic: [PATCH v3 01/15] dmaengine: dw: fix master selection Thread-Index: AQHRgSIbg46P1QDfBEGLZjz90UyEKZ96JZeA//+l1QCAA55ngP//tIwAgAAUdgA= Date: Wed, 6 Apr 2016 21:09:48 +0000 Message-ID: <1459976988.3136.83.camel@intel.com> References: <1458311094-94927-1-git-send-email-andriy.shevchenko@linux.intel.com> <1458311094-94927-2-git-send-email-andriy.shevchenko@linux.intel.com> <20160404170337.GC3515@vkoul-mobl.iind.intel.com> <1459789854.12167.6.camel@linux.intel.com> <20160406185637.GA5168@vkoul-mobl.iind.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.186.54] Content-Type: text/plain; charset="utf-8" Content-ID: <99A944BA652F8E49A642F14964C7579F@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u36LACfN005315 On Wed, 2016-04-06 at 22:56 +0300, Andy Shevchenko wrote: > On Wed, Apr 6, 2016 at 9:56 PM, Vinod Koul > wrote: > > On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: > > > On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote: > > > > On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote: > > > > > > > > > > + /* > > > > > + * We need controller-specific data to set up slave > > > > > transfers. > > > > > + */ > > > > > + BUG_ON(chan->private && !dw_dma_filter(chan, chan- > > > > > > private)); > > > > I don't think BUG_ON is apt here, gracefully failing and > > > > printing > > > > that can > > > > be better.. > > > > > > Hm, this is coming from the existing code. > > > > > > I would prefer to keep this one as is since it's targeted to > > > stable@, > > > and I may issue sequential patch to replace BUG_ON. Sounds okay? > > > > But since this is going stable, how about we remove here in the > > patch and > > benefit stable tree as well? > > I'm fine with that. I will send you patch tomorrow.Other than that do > we have any issues with the rest? I did look at few more they looked fine, but didn't look at entire series -- ~Vinod