From: Laxman Dewangan <ldewangan@nvidia.com>
To: <lee.jones@linaro.org>, <corbet@lwn.net>, <andreas.werner@men.de>,
<tony@atomide.com>
Cc: <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<patches@opensource.wolfsonmicro.com>,
"Laxman Dewangan" <ldewangan@nvidia.com>,
Gyungoh Yoo <jack.yoo@skyworksinc.com>
Subject: [PATCH V2 15/20] mfd: sky81452: Use devm_mfd_add_devices() for mfd_device registration
Date: Fri, 8 Apr 2016 00:13:09 +0530 [thread overview]
Message-ID: <1460054594-32325-16-git-send-email-ldewangan@nvidia.com> (raw)
In-Reply-To: <1460054594-32325-1-git-send-email-ldewangan@nvidia.com>
Use devm_mfd_add_devices() for MFD devices registration and get
rid of .remove callback to remove MFD child-devices. This is done
by managed device framework.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
CC: Gyungoh Yoo <jack.yoo@skyworksinc.com>
---
Changes from V1:
- Convert mfd to MFD.
- Run checkpatch with --strict option and fix warning.
drivers/mfd/sky81452.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/sky81452.c b/drivers/mfd/sky81452.c
index b0c9b04..30a2a67 100644
--- a/drivers/mfd/sky81452.c
+++ b/drivers/mfd/sky81452.c
@@ -64,19 +64,14 @@ static int sky81452_probe(struct i2c_client *client,
cells[1].platform_data = pdata->regulator_init_data;
cells[1].pdata_size = sizeof(*pdata->regulator_init_data);
- ret = mfd_add_devices(dev, -1, cells, ARRAY_SIZE(cells), NULL, 0, NULL);
+ ret = devm_mfd_add_devices(dev, -1, cells, ARRAY_SIZE(cells),
+ NULL, 0, NULL);
if (ret)
dev_err(dev, "failed to add child devices. err=%d\n", ret);
return ret;
}
-static int sky81452_remove(struct i2c_client *client)
-{
- mfd_remove_devices(&client->dev);
- return 0;
-}
-
static const struct i2c_device_id sky81452_ids[] = {
{ "sky81452" },
{ }
@@ -97,7 +92,6 @@ static struct i2c_driver sky81452_driver = {
.of_match_table = of_match_ptr(sky81452_of_match),
},
.probe = sky81452_probe,
- .remove = sky81452_remove,
.id_table = sky81452_ids,
};
--
2.1.4
next prev parent reply other threads:[~2016-04-07 18:56 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 18:42 [PATCH V2 00/20] mfd: Add devm_ apis for mfd_add_devices and mfd_release_devices Laxman Dewangan
2016-04-07 18:42 ` [PATCH V2 01/20] mfd: Add resource managed apis for mfd_add_devices Laxman Dewangan
2016-04-11 9:15 ` Lee Jones
2016-04-07 18:42 ` [PATCH V2 02/20] mfd: Add devm_mfd_add_devices() in list of managed interfaces Laxman Dewangan
2016-04-11 9:15 ` Lee Jones
2016-04-07 18:42 ` [PATCH V2 03/20] mfd: act8945a: Use devm_mfd_add_devices() for mfd_device registration Laxman Dewangan
2016-04-11 9:15 ` Lee Jones
2016-04-07 18:42 ` [PATCH V2 04/20] mfd: as3711: " Laxman Dewangan
2016-04-11 9:15 ` Lee Jones
2016-04-07 18:42 ` [PATCH V2 05/20] mfd: atmel-hlcdc: " Laxman Dewangan
2016-04-11 9:15 ` Lee Jones
2016-04-07 18:43 ` [PATCH V2 06/20] mfd: bcm590xx: " Laxman Dewangan
2016-04-11 9:15 ` Lee Jones
2016-04-07 18:43 ` [PATCH V2 07/20] mfd: hi6421-pmic: " Laxman Dewangan
2016-04-11 9:15 ` Lee Jones
2016-04-07 18:43 ` [PATCH V2 08/20] mfd: lp3943: " Laxman Dewangan
2016-04-11 9:16 ` Lee Jones
2016-04-07 18:43 ` [PATCH V2 09/20] mfd: menf21bmc: " Laxman Dewangan
2016-04-11 9:16 ` Lee Jones
2016-04-07 18:43 ` [PATCH V2 10/20] mfd: mt6397: " Laxman Dewangan
2016-04-11 9:31 ` Lee Jones
2016-04-07 18:43 ` [PATCH V2 11/20] mfd: rdc321x: " Laxman Dewangan
2016-04-11 9:31 ` Lee Jones
2016-04-07 18:43 ` [PATCH V2 12/20] mfd: rk808: " Laxman Dewangan
2016-04-11 9:31 ` Lee Jones
2016-04-07 18:43 ` [PATCH V2 13/20] mfd: rn5t618: " Laxman Dewangan
2016-04-11 9:31 ` Lee Jones
2016-04-07 18:43 ` [PATCH V2 14/20] mfd: rt5033: " Laxman Dewangan
2016-04-11 9:31 ` Lee Jones
2016-04-07 18:43 ` Laxman Dewangan [this message]
2016-04-11 9:31 ` [PATCH V2 15/20] mfd: sky81452: " Lee Jones
2016-04-07 18:43 ` [PATCH V2 16/20] mfd: stw481x: " Laxman Dewangan
2016-04-11 9:32 ` Lee Jones
2016-04-07 18:43 ` [PATCH V2 17/20] mfd: tps6507x: " Laxman Dewangan
2016-04-11 9:32 ` Lee Jones
2016-04-07 18:43 ` [PATCH V2 18/20] mfd: tps65217: " Laxman Dewangan
2016-04-11 9:32 ` Lee Jones
2016-04-07 18:43 ` [PATCH V2 19/20] mfd: tps65910: " Laxman Dewangan
2016-04-11 9:32 ` Lee Jones
2016-04-07 18:43 ` [PATCH V2 20/20] mfd: wm8400: " Laxman Dewangan
2016-04-11 9:32 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460054594-32325-16-git-send-email-ldewangan@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=andreas.werner@men.de \
--cc=corbet@lwn.net \
--cc=jack.yoo@skyworksinc.com \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox