From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758196AbcDHKuc (ORCPT ); Fri, 8 Apr 2016 06:50:32 -0400 Received: from smtprelay0114.hostedemail.com ([216.40.44.114]:54778 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757973AbcDHKub (ORCPT ); Fri, 8 Apr 2016 06:50:31 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:152:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2689:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:4250:4321:5007:6119:7809:10004:10400:10848:11026:11232:11658:11783:11914:12043:12296:12517:12519:12740:13069:13311:13357:13894:13972:14181:14659:14721:21080:30003:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: way57_5a348718bba25 X-Filterd-Recvd-Size: 2806 Message-ID: <1460112618.1800.36.camel@perches.com> Subject: Re: [PATCH] mtd: nand: pasemi: switch to pr_* functions From: Joe Perches To: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Boris Brezillon Cc: Richard Weinberger , linux-mtd@lists.infradead.org, Olof Johansson , David Woodhouse , Brian Norris , "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" , open list Date: Fri, 08 Apr 2016 03:50:18 -0700 In-Reply-To: <1460111589-18781-1-git-send-email-zajec5@gmail.com> References: <1460111589-18781-1-git-send-email-zajec5@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-04-08 at 12:33 +0200, Rafał Miłecki wrote: > This patch also replaces %08llx with %08zx for printing resource start > address. Old format was triggering: > warning: format ‘%08llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘resource_size_t’ trivia: > diff --git a/drivers/mtd/nand/pasemi_nand.c b/drivers/mtd/nand/pasemi_nand.c [] > @@ -112,8 +112,7 @@ static int pasemi_nand_probe(struct platform_device *ofdev) >   /* Allocate memory for MTD device structure and private data */ >   chip = kzalloc(sizeof(struct nand_chip), GFP_KERNEL); >   if (!chip) { > - printk(KERN_WARNING > -        "Unable to allocate PASEMI NAND MTD device structure\n"); > + pr_warn("Unable to allocate PASEMI NAND MTD device structure\n"); Maybe remove this unnecessary as there's an OOM stack dump. >   err = -ENOMEM; >   goto out; >   } > @@ -163,13 +162,13 @@ static int pasemi_nand_probe(struct platform_device *ofdev) >   } >   >   if (mtd_device_register(pasemi_nand_mtd, NULL, 0)) { > - printk(KERN_ERR "pasemi_nand: Unable to register MTD device\n"); > + pr_err("pasemi_nand: Unable to register MTD device\n"); Maybe remove the embedded "pasemi_nand: " and add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt before the first #include? >   err = -ENODEV; >   goto out_lpc; >   } >   > - printk(KERN_INFO "PA Semi NAND flash at %08llx, control at I/O %x\n", > -        res.start, lpcctl); > + pr_info("PA Semi NAND flash at %08zx, control at I/O %x\n", res.start, > + lpcctl); Maybe use %pR, &res instead of res.start? pr_info("PA Semi NAND flash at %pR, control at I/O %x\n", &res, lpcctl);