From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758086AbcDHLOF (ORCPT ); Fri, 8 Apr 2016 07:14:05 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:33486 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757497AbcDHLOD (ORCPT ); Fri, 8 Apr 2016 07:14:03 -0400 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: Boris Brezillon Cc: Richard Weinberger , linux-mtd@lists.infradead.org, Egor Martovetsky , Olof Johansson , Joe Perches , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , David Woodhouse , Brian Norris , linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC PA SEMI PWRFICIENT), linux-kernel@vger.kernel.org (open list) Subject: [PATCH V2] mtd: nand: pasemi: switch to pr_* functions Date: Fri, 8 Apr 2016 13:13:23 +0200 Message-Id: <1460114003-19926-1-git-send-email-zajec5@gmail.com> X-Mailer: git-send-email 1.8.4.5 In-Reply-To: <1460111589-18781-1-git-send-email-zajec5@gmail.com> References: <1460111589-18781-1-git-send-email-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 1) Use pr_fmt to keep messages consistent 2) Don't warn if kzalloc fails as it dumps stack on its own 3) Use %pR format for displaying whole resource to avoid: warning: format ‘%08llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘resource_size_t’ Signed-off-by: Rafał Miłecki --- drivers/mtd/nand/pasemi_nand.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/nand/pasemi_nand.c b/drivers/mtd/nand/pasemi_nand.c index 63fcb8c..e8372b4 100644 --- a/drivers/mtd/nand/pasemi_nand.c +++ b/drivers/mtd/nand/pasemi_nand.c @@ -22,6 +22,8 @@ #undef DEBUG +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include #include #include @@ -112,8 +114,6 @@ static int pasemi_nand_probe(struct platform_device *ofdev) /* Allocate memory for MTD device structure and private data */ chip = kzalloc(sizeof(struct nand_chip), GFP_KERNEL); if (!chip) { - printk(KERN_WARNING - "Unable to allocate PASEMI NAND MTD device structure\n"); err = -ENOMEM; goto out; } @@ -163,13 +163,12 @@ static int pasemi_nand_probe(struct platform_device *ofdev) } if (mtd_device_register(pasemi_nand_mtd, NULL, 0)) { - printk(KERN_ERR "pasemi_nand: Unable to register MTD device\n"); + pr_err("Unable to register MTD device\n"); err = -ENODEV; goto out_lpc; } - printk(KERN_INFO "PA Semi NAND flash at %08llx, control at I/O %x\n", - res.start, lpcctl); + pr_info("PA Semi NAND flash at %pR, control at I/O %x\n", &res, lpcctl); return 0; -- 1.8.4.5