From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758649AbcDHQuS (ORCPT ); Fri, 8 Apr 2016 12:50:18 -0400 Received: from smtprelay0203.hostedemail.com ([216.40.44.203]:46648 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753864AbcDHQuP (ORCPT ); Fri, 8 Apr 2016 12:50:15 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:152:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1566:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2689:3138:3139:3140:3141:3142:3622:3867:3872:4321:4362:5007:10004:10400:10848:11026:11658:11914:12296:12517:12519:12740:13069:13311:13357:13894:14659:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: knot09_1d15b892db940 X-Filterd-Recvd-Size: 1552 Message-ID: <1460134198.1800.37.camel@perches.com> Subject: Re: [PATCH V2] mtd: nand: pasemi: switch to pr_* functions From: Joe Perches To: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Boris Brezillon Cc: Richard Weinberger , linux-mtd@lists.infradead.org, Egor Martovetsky , Olof Johansson , David Woodhouse , Brian Norris , "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" , open list Date: Fri, 08 Apr 2016 09:49:58 -0700 In-Reply-To: <1460114003-19926-1-git-send-email-zajec5@gmail.com> References: <1460111589-18781-1-git-send-email-zajec5@gmail.com> <1460114003-19926-1-git-send-email-zajec5@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-04-08 at 13:13 +0200, Rafał Miłecki wrote: > 1) Use pr_fmt to keep messages consistent > 2) Don't warn if kzalloc fails as it dumps stack on its own > 3) Use %pR format for displaying whole resource to avoid: > warning: format ‘%08llx’ expects type ‘long long unsigned int’, but > argument 2 has type ‘resource_size_t’ thanks