Re: [PATCH v5 01/14] x86/boot: enumerate documentation for the x86 hardware_subarch

Luis R. Rodriguez
2016-04-13T15:17:26Z

On Wed, Apr 13, 2016 at 10:01:32AM +0200, Ingo Molnar wrote:
> > diff --git a/arch/x86/include/uapi/asm/bootparam.h b/arch/x86/include/uapi/asm/bootparam.h
> > index 329254373479..bf9fea2f4591 100644
> > --- a/arch/x86/include/uapi/asm/bootparam.h
> > +++ b/arch/x86/include/uapi/asm/bootparam.h
> > @@ -157,7 +157,42 @@ struct boot_params {
> > __u8 _pad9[276]; /* 0xeec */
> > } __attribute__((packed));
> >
> > -enum {
> > +/**
> > + * enum x86_hardware_subarch - x86 hardware subarchitecture
>
> Could you add some prominent warning here, like:
>
> > + * WARNING: the 'x86 subarch flag' is only used for legacy hacks, for platform
> > + * features that are not easily enumerated or discoverable. You should
> > + * not ever use this for new features.

With pleasure, added.

Luis