From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754117AbcDKLKX (ORCPT ); Mon, 11 Apr 2016 07:10:23 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34035 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753703AbcDKLIk (ORCPT ); Mon, 11 Apr 2016 07:08:40 -0400 From: Michal Hocko To: Cc: Andrew Morton , LKML , Michal Hocko , Shaohua Li , Mikulas Patocka Subject: [PATCH 17/19] dm: get rid of superfluous gfp flags Date: Mon, 11 Apr 2016 13:08:10 +0200 Message-Id: <1460372892-8157-18-git-send-email-mhocko@kernel.org> X-Mailer: git-send-email 2.8.0.rc3 In-Reply-To: <1460372892-8157-1-git-send-email-mhocko@kernel.org> References: <1460372892-8157-1-git-send-email-mhocko@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Hocko copy_params seems to be little bit confused about which allocation flags to use. It enforces GFP_NOIO even though it uses memalloc_noio_{save,restore} which enforces GFP_NOIO at the page allocator level automatically (via memalloc_noio_flags). It also uses __GFP_REPEAT for the __vmalloc request which doesn't make much sense either because vmalloc doesn't rely on costly high order allocations. Cc: Shaohua Li Cc: Mikulas Patocka Signed-off-by: Michal Hocko --- drivers/md/dm-ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c index 2adf81d81fca..dfe629a294e1 100644 --- a/drivers/md/dm-ioctl.c +++ b/drivers/md/dm-ioctl.c @@ -1723,7 +1723,7 @@ static int copy_params(struct dm_ioctl __user *user, struct dm_ioctl *param_kern if (!dmi) { unsigned noio_flag; noio_flag = memalloc_noio_save(); - dmi = __vmalloc(param_kernel->data_size, GFP_NOIO | __GFP_REPEAT | __GFP_HIGH | __GFP_HIGHMEM, PAGE_KERNEL); + dmi = __vmalloc(param_kernel->data_size, __GFP_HIGH | __GFP_HIGHMEM, PAGE_KERNEL); memalloc_noio_restore(noio_flag); if (dmi) *param_flags |= DM_PARAMS_VMALLOC; -- 2.8.0.rc3