linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Vagin <avagin@openvz.org>
To: linux-kernel@vger.kernel.org
Cc: Andrey Vagin <avagin@openvz.org>, Oleg Nesterov <oleg@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Cyrill Gorcunov <gorcunov@openvz.org>,
	Pavel Emelyanov <xemul@parallels.com>,
	Roger Luethi <rl@hellgate.ch>, Arnd Bergmann <arnd@arndb.de>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	David Ahern <dsahern@gmail.com>,
	Andy Lutomirski <luto@amacapital.net>,
	Pavel Odintsov <pavel.odintsov@gmail.com>
Subject: [PATCH 08/15] task_diag: Only add VMAs for thread_group leader
Date: Mon, 11 Apr 2016 16:35:48 -0700	[thread overview]
Message-ID: <1460417755-18201-9-git-send-email-avagin@openvz.org> (raw)
In-Reply-To: <1460417755-18201-1-git-send-email-avagin@openvz.org>

From: David Ahern <dsahern@gmail.com>

threads of a process share the same VMAs, so when dumping all threads
for all processes only push vma data for group leader.

Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
---
 fs/proc/task_diag.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/fs/proc/task_diag.c b/fs/proc/task_diag.c
index e0f0b03..00db32d 100644
--- a/fs/proc/task_diag.c
+++ b/fs/proc/task_diag.c
@@ -433,7 +433,17 @@ static int task_diag_fill(struct task_struct *tsk, struct sk_buff *skb,
 	}
 
 	if (show_flags & TASK_DIAG_SHOW_VMA) {
-		if (i >= n)
+		bool dump_vma = true;
+
+		/* if the request is to dump all threads of all processes
+		 * only show VMAs for group leader.
+		 */
+		if ((req->dump_strategy == TASK_DIAG_DUMP_ALL_THREAD ||
+		     req->dump_strategy == TASK_DIAG_DUMP_THREAD) &&
+		    !thread_group_leader(tsk))
+			dump_vma = false;
+
+		if (dump_vma && i >= n)
 			err = fill_vma(tsk, skb, cb, &progress, show_flags);
 		if (err)
 			goto err;
-- 
2.5.5

  parent reply	other threads:[~2016-04-11 23:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11 23:35 [PATCH 0/15] task_diag: add a new interface to get information about processes (v3) Andrey Vagin
2016-04-11 23:35 ` [PATCH 01/15] proc: pick out a function to iterate task children Andrey Vagin
2016-04-11 23:35 ` [PATCH 02/15] proc: export task_first_tid() and task_next_tid() Andrey Vagin
2016-04-11 23:35 ` [PATCH 03/15] proc: export next_tgid() Andrey Vagin
2016-04-11 23:35 ` [PATCH 04/15] task_diag: add a new interface to get information about tasks (v4) Andrey Vagin
2016-04-12  1:03   ` kbuild test robot
2016-04-13  0:45     ` Andrew Vagin
2016-04-12  7:08   ` Cyrill Gorcunov
2016-04-13  0:39     ` Andrew Vagin
2016-04-13  5:26       ` Cyrill Gorcunov
2016-04-11 23:35 ` [PATCH 05/15] task_diag: add a new group to get process credentials Andrey Vagin
2016-04-11 23:35 ` [PATCH 06/15] task_diag: add a new group to get tasks memory mappings (v2) Andrey Vagin
2016-04-11 23:35 ` [PATCH 07/15] task_diag: add ability to dump children and threads Andrey Vagin
2016-04-11 23:35 ` Andrey Vagin [this message]
2016-04-11 23:35 ` [PATCH 09/15] task_diag: add a flag to mark incomplete messages Andrey Vagin
2016-04-11 23:35 ` [PATCH 10/15] task_diag: add a new group to get resource usage Andrey Vagin
2016-04-11 23:35 ` [PATCH 11/15] task_diag: add a new group to get memory usage Andrey Vagin
2016-04-11 23:35 ` [PATCH 12/15] Documentation: add documentation for task_diag Andrey Vagin
2016-04-11 23:35 ` [PATCH 13/15] selftest: check the task_diag functinonality Andrey Vagin
2016-04-11 23:35 ` [PATCH 14/15] task_diag: Enhance fork tool to spawn threads Andrey Vagin
2016-04-11 23:35 ` [PATCH 15/15] test: check that task_diag can dump all thread of one process Andrey Vagin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460417755-18201-9-git-send-email-avagin@openvz.org \
    --to=avagin@openvz.org \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=dsahern@gmail.com \
    --cc=gorcunov@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=oleg@redhat.com \
    --cc=pavel.odintsov@gmail.com \
    --cc=rl@hellgate.ch \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).