From: changbin.du@intel.com
To: balbi@kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, "Du,
Changbin" <changbin.du@intel.com>
Subject: [PATCH v3] usb: dwc3: fix memory leak of dwc->regset
Date: Tue, 12 Apr 2016 16:24:34 +0800 [thread overview]
Message-ID: <1460449474-26540-1-git-send-email-changbin.du@intel.com> (raw)
In-Reply-To: <87k2k3kzbe.fsf@intel.com>
From: "Du, Changbin" <changbin.du@intel.com>
dwc->regset is allocated on dwc3_debugfs_init, and should
be released on init failure or dwc3_debugfs_exit. Btw,
The line "dwc->root = NULL" is unnecessary, so remove it.
Signed-off-by: Du, Changbin <changbin.du@intel.com>
---
v3:
remove unnecessary if(!NULL) for free
v2:
Title changed;
free dwc->regset on failure path.
---
drivers/usb/dwc3/debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
index 9ac37fe..07d99eb 100644
--- a/drivers/usb/dwc3/debugfs.c
+++ b/drivers/usb/dwc3/debugfs.c
@@ -678,7 +678,7 @@ int dwc3_debugfs_init(struct dwc3 *dwc)
err1:
debugfs_remove_recursive(root);
-
+ kfree(dwc->regset);
err0:
return ret;
}
@@ -686,5 +686,5 @@ err0:
void dwc3_debugfs_exit(struct dwc3 *dwc)
{
debugfs_remove_recursive(dwc->root);
- dwc->root = NULL;
+ kfree(dwc->regset);
}
--
2.5.0
next prev parent reply other threads:[~2016-04-12 8:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 9:42 [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit changbin.du
2016-04-11 8:06 ` Felipe Balbi
2016-04-11 11:09 ` Du, Changbin
2016-04-11 11:13 ` Felipe Balbi
2016-04-11 11:38 ` Du, Changbin
2016-04-11 12:09 ` Felipe Balbi
2016-04-12 2:10 ` Du, Changbin
2016-04-12 6:18 ` Felipe Balbi
2016-04-12 6:52 ` Du, Changbin
2016-04-12 8:06 ` Felipe Balbi
2016-04-12 8:14 ` [PATCH v2] usb: dwc3: fix memory leak of dwc->regset changbin.du
2016-04-12 8:26 ` Felipe Balbi
2016-04-12 8:24 ` changbin.du [this message]
2016-04-12 10:09 ` [PATCH v3] " Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460449474-26540-1-git-send-email-changbin.du@intel.com \
--to=changbin.du@intel.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox