public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Denys Vlasenko <dvlasenk@redhat.com>,
	Johan Hedberg <johan.hedberg@intel.com>
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Bluetooth: Deinline large functions
Date: Tue, 12 Apr 2016 09:14:50 -0700	[thread overview]
Message-ID: <1460477690.2507.5.camel@perches.com> (raw)
In-Reply-To: <570D1D9A.6030808@redhat.com>

On Tue, 2016-04-12 at 18:08 +0200, Denys Vlasenko wrote:
> On 04/12/2016 05:50 AM, Joe Perches wrote:
> > 
> > On Mon, 2016-04-11 at 20:34 +0200, Denys Vlasenko wrote:
> > > 
> > > Fastest existing Bluetooth standard's top speed is 2.4 MB/s.
> > > It is way off from being CPU limited, no need to squeeze
> > > last few cycles by excessive inlining.
> > > 
> > > Size reduction is about 40k:
> > > 
> > >     text     data      bss       dec     hex filename
> > > 95943139 20860256 35991552 152794947 91b7743 vmlinux_before
> > > 95903714 20860256 35991552 152755522 91add42 vmlinux
> > defconfig?
> In defconfig, CONFIG_BT is not set, so there will be no change

Which is why I set it in the defconfig size I sent.

Also, you haven't responded at all to any performance decrease
by uninline for low power/low frequency SOC embedded uses.

  reply	other threads:[~2016-04-12 16:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11 18:34 [PATCH v2] Bluetooth: Deinline large functions Denys Vlasenko
2016-04-12  3:50 ` Joe Perches
2016-04-12 16:08   ` Denys Vlasenko
2016-04-12 16:14     ` Joe Perches [this message]
2016-04-12 16:31       ` Denys Vlasenko
2016-04-12 17:00         ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460477690.2507.5.camel@perches.com \
    --to=joe@perches.com \
    --cc=dvlasenk@redhat.com \
    --cc=johan.hedberg@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox