From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754145AbcDMV1Q (ORCPT ); Wed, 13 Apr 2016 17:27:16 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36457 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751972AbcDMV1O (ORCPT ); Wed, 13 Apr 2016 17:27:14 -0400 From: David Daney To: Jack Wang , lindar_liu@usish.com, "James E.J. Bottomley" , "Martin K. Petersen" , pmchba@pmcs.com, linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, David Daney Subject: [PATCH] pm80xx: Remove bogus address masking in pm8001_ioremap() Date: Wed, 13 Apr 2016 14:26:56 -0700 Message-Id: <1460582816-12703-1-git-send-email-ddaney.cavm@gmail.com> X-Mailer: git-send-email 1.7.11.7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Daney It is unclear what the original intent of the masking was, but it is clearly incorrect to truncate a physical address before calling ioremap(). On systems where there are valid physical address bits above bit-31 (arm64 for example) the result is an eventual OOPs when initializing the driver. Remove the bogus code to fix it. Signed-off-by: David Daney --- drivers/scsi/pm8001/pm8001_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c index 062ab34..6bd7bf4 100644 --- a/drivers/scsi/pm8001/pm8001_init.c +++ b/drivers/scsi/pm8001/pm8001_init.c @@ -418,8 +418,6 @@ static int pm8001_ioremap(struct pm8001_hba_info *pm8001_ha) if (pci_resource_flags(pdev, bar) & IORESOURCE_MEM) { pm8001_ha->io_mem[logicalBar].membase = pci_resource_start(pdev, bar); - pm8001_ha->io_mem[logicalBar].membase &= - (u32)PCI_BASE_ADDRESS_MEM_MASK; pm8001_ha->io_mem[logicalBar].memsize = pci_resource_len(pdev, bar); pm8001_ha->io_mem[logicalBar].memvirtaddr = -- 1.8.3.1