From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752645AbcDOMpG (ORCPT ); Fri, 15 Apr 2016 08:45:06 -0400 Received: from mga02.intel.com ([134.134.136.20]:7413 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751326AbcDOMpE (ORCPT ); Fri, 15 Apr 2016 08:45:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,487,1455004800"; d="scan'208";a="85775922" Message-ID: <1460724334.6620.189.camel@linux.intel.com> Subject: Re: [PATCH v3 08/15] dmaengine: dw: revisit data_width property From: Andy Shevchenko To: Mark Brown Cc: Vinod Koul , Viresh Kumar , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Rob Herring , Hans-Christian Egtvedt , Tejun Heo , Greg Kroah-Hartman , Mark Rutland , Vineet Gupta Date: Fri, 15 Apr 2016 15:45:34 +0300 In-Reply-To: <20160413164035.GA29471@sirena.org.uk> References: <1458311094-94927-1-git-send-email-andriy.shevchenko@linux.intel.com> <1458311094-94927-9-git-send-email-andriy.shevchenko@linux.intel.com> <20160413155719.GS2274@localhost> <1460563548.6620.165.camel@linux.intel.com> <20160413161715.GU2274@localhost> <1460564513.6620.170.camel@linux.intel.com> <20160413164035.GA29471@sirena.org.uk> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-04-13 at 17:40 +0100, Mark Brown wrote: > On Wed, Apr 13, 2016 at 07:21:53PM +0300, Andy Shevchenko wrote: > > > > On Wed, 2016-04-13 at 21:47 +0530, Vinod Koul wrote: > > > > > > On Wed, Apr 13, 2016 at 07:05:48PM +0300, Andy Shevchenko wrote: > > > > > > > > > > > > > The old is still supported and benefit is apparently in unifying > > > > standard properties across the drivers. > > > > > > > > Hrmmm how is that? > > > > The common usage for data-width property is "in bytes". And I like > > the > > idea. I don't know why at all I chose to keep encoded value there in > > the > > first place and no one commented at that time. I suppose because of > > screwed device tree process. I think now it's better to follow some > > standard / registered properties in new drivers. > You're unfortunately still breaking compatibility with existing DTs > using this property.  Now, it does appear that there is very little > use > of this DMA controller on DT systems and judging by the somewhat odd > compatible string and in tree DTs most of those are legacy so perhaps > this isn't the end of the world but this isn't something that should > be > dismissed as a simple cleanup. Well, does everyone agree that keeping data-width a) with dash in the name and b) in bytes is good approach? I will keep an array and support for old encoded property though. -- Andy Shevchenko Intel Finland Oy