From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751957AbcDOOkJ (ORCPT ); Fri, 15 Apr 2016 10:40:09 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:35782 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbcDOOkI (ORCPT ); Fri, 15 Apr 2016 10:40:08 -0400 Message-ID: <1460731203.2331.7.camel@HansenPartnership.com> Subject: Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646 From: James Bottomley To: Denys Vlasenko , Himanshu Madhani Cc: qla2xxx-upstream@qlogic.com, Josh Poimboeuf , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 15 Apr 2016 07:40:03 -0700 In-Reply-To: <1460716583-15673-1-git-send-email-dvlasenk@redhat.com> References: <1460716583-15673-1-git-send-email-dvlasenk@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-04-15 at 12:36 +0200, Denys Vlasenko wrote: > More info here: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646 This bug is under investigation, so I'd rather not alter code for a gcc bug until we know if we can supply options to fix it rather than changing code. James > Signed-off-by: Denys Vlasenko > CC: Himanshu Madhani > CC: James Bottomley > CC: qla2xxx-upstream@qlogic.com > CC: Josh Poimboeuf > CC: linux-scsi@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- > drivers/scsi/qla2xxx/qla_attr.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/scsi/qla2xxx/qla_attr.c > b/drivers/scsi/qla2xxx/qla_attr.c > index 4dc06a13..2dd9c72 100644 > --- a/drivers/scsi/qla2xxx/qla_attr.c > +++ b/drivers/scsi/qla2xxx/qla_attr.c > @@ -2003,9 +2003,14 @@ static void > qla2x00_get_host_fabric_name(struct Scsi_Host *shost) > { > scsi_qla_host_t *vha = shost_priv(shost); > + /* > + * This can trigger gcc 4.9/5.3 bug. > + * See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646 > uint8_t node_name[WWN_SIZE] = { 0xFF, 0xFF, 0xFF, 0xFF, \ > 0xFF, 0xFF, 0xFF, 0xFF}; > u64 fabric_name = wwn_to_u64(node_name); > + */ > + u64 fabric_name = (u64)(s64)-1; /* the same as above */ > > if (vha->device_flags & SWITCH_FOUND) > fabric_name = wwn_to_u64(vha->fabric_node_name);