From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751352AbcDOUXu (ORCPT ); Fri, 15 Apr 2016 16:23:50 -0400 Received: from smtprelay0131.hostedemail.com ([216.40.44.131]:55833 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750947AbcDOUXt (ORCPT ); Fri, 15 Apr 2016 16:23:49 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:152:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3868:3870:3872:4250:4321:5007:6119:7514:7809:7901:9040:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12517:12519:12555:12740:13069:13138:13231:13255:13311:13357:13894:14181:14659:14721:21080:21220:30054:30069:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: brain99_7860ec8978f5f X-Filterd-Recvd-Size: 2183 Message-ID: <1460751818.19090.43.camel@perches.com> Subject: Re: [PATCH 09/12] mtd: nand: fsmc: validate ECC setup by checking algorithm directly From: Joe Perches To: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Boris Brezillon Cc: linux-mtd@lists.infradead.org, Richard Weinberger , David Woodhouse , Brian Norris , open list Date: Fri, 15 Apr 2016 13:23:38 -0700 In-Reply-To: <1460750052-16285-10-git-send-email-zajec5@gmail.com> References: <1460750052-16285-1-git-send-email-zajec5@gmail.com> <1460750052-16285-10-git-send-email-zajec5@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-04-15 at 21:54 +0200, Rafał Miłecki wrote: > NAND core sets ECC algorithm in algo field now and it should be > preferred over the mode field. This also prepares driver for dropping > NAND_ECC_SOFT_BCH. > > Signed-off-by: Rafał Miłecki > --- >  drivers/mtd/nand/fsmc_nand.c | 7 +++++-- >  1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c > index 1372040..0f8c63f 100644 > --- a/drivers/mtd/nand/fsmc_nand.c > +++ b/drivers/mtd/nand/fsmc_nand.c > @@ -958,9 +958,12 @@ static int __init fsmc_nand_probe(struct platform_device *pdev) >   nand->ecc.strength = 1; >   break; >   > + case NAND_ECC_SOFT: >   case NAND_ECC_SOFT_BCH: > - dev_info(&pdev->dev, "Using 4-bit SW BCH ECC scheme\n"); > - break; > + if (nand->ecc.algo == NAND_ECC_BCH) { > + dev_info(&pdev->dev, "Using 4-bit SW BCH ECC scheme\n"); > + break; > + } >   >   default: >   dev_err(&pdev->dev, "Unsupported ECC mode!\n"); Why not just add NAND_ECC_SOFT above the default case?