From: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
To: corentin.chary@gmail.com, dvhart@infradead.org
Cc: acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
Subject: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set
Date: Sat, 16 Apr 2016 03:01:57 +0300 [thread overview]
Message-ID: <1460764917-1042-2-git-send-email-giedrius.statkevicius@gmail.com> (raw)
In-Reply-To: <1460764917-1042-1-git-send-email-giedrius.statkevicius@gmail.com>
Properly return rv back to the caller in the case of an error in
parse_arg. In the process remove a unused variable 'out'.
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
---
drivers/platform/x86/asus-laptop.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index d86d42e..9a69734 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -946,11 +946,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
const char *method)
{
int rv, value;
- int out = 0;
rv = parse_arg(buf, count, &value);
- if (rv > 0)
- out = value ? 1 : 0;
+ if (rv <= 0)
+ return rv;
if (write_acpi_int(asus->handle, method, value))
return -ENODEV;
--
2.8.0
next prev parent reply other threads:[~2016-04-16 0:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-16 0:01 [PATCH v2 1/2] asus-laptop: remove redundant initializers Giedrius Statkevičius
2016-04-16 0:01 ` Giedrius Statkevičius [this message]
2016-04-20 20:19 ` [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Darren Hart
2016-04-21 6:35 ` Giedrius Statkevičius
2016-04-21 20:34 ` Andy Shevchenko
2016-04-21 20:59 ` Darren Hart
2016-04-25 17:47 ` Darren Hart
2016-04-21 23:01 ` [PATCH v2 1/2] asus-laptop: remove redundant initializers Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460764917-1042-2-git-send-email-giedrius.statkevicius@gmail.com \
--to=giedrius.statkevicius@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).