From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752571AbcDRNAH (ORCPT ); Mon, 18 Apr 2016 09:00:07 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:44985 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751619AbcDRNAF (ORCPT ); Mon, 18 Apr 2016 09:00:05 -0400 Message-ID: <1460984397.4462.4.camel@mtksdaap41> Subject: Re: [PATCH v3] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver From: PC Liao To: Mark Brown CC: "tiwai@suse.de" , srv_heupstream , "linux-mediatek@lists.infradead.org" , "s.hauer@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" , "Koro Chen =?UTF-8?Q?=28=E9=99=B3=E6=80=9D=E7=BF=B0=29?=" Date: Mon, 18 Apr 2016 20:59:57 +0800 In-Reply-To: <20160418120352.GZ3217@sirena.org.uk> References: <1460014517-20359-1-git-send-email-pc.liao@mediatek.com> <1460979380.17045.2.camel@mtksdaap41> <20160418120352.GZ3217@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On Mon, 2016-04-18 at 20:03 +0800, Mark Brown wrote: > On Mon, Apr 18, 2016 at 07:36:20PM +0800, PC Liao wrote: > > > Could you please give some comments or suggestions? > > I don't have these patches. If you're getting review comments from > other people please address them, it's quite possible I saw them and > agreed with them. > > Please don't send content free pings and please allow a reasonable time > for review. People get busy, go on holiday, attend conferences and so > on so unless there is some reason for urgency (like critical bug fixes) > please allow at least a couple of weeks for review. Sending content > free pings just adds to the mail volume (if they are seen at all) and if > something has gone wrong you'll have to resend the patches anyway. I am so sorry about that.......... I have sent v4. Thanks for your review and help.