From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752137AbcDROlI (ORCPT ); Mon, 18 Apr 2016 10:41:08 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:43988 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbcDROlG (ORCPT ); Mon, 18 Apr 2016 10:41:06 -0400 X-AuditID: cbfee61a-f79a86d000001a1a-6d-5714f20039c3 From: Jacek Anaszewski To: linux-leds@vger.kernel.org Cc: linux-kernel@vger.kernel.org, rpurdie@rpsys.net, boris.brezillon@free-electrons.com, ezequiel@vanguardiasur.com.ar, pavel@ucw.cz, Jacek Anaszewski Subject: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity() Date: Mon, 18 Apr 2016 16:40:46 +0200 Message-id: <1460990446-24700-1-git-send-email-j.anaszewski@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpiluLIzCtJLcpLzFFi42I5/e+xoC7DJ5Fwg7mfxC0OvFjIYrHxxWcW i96rzxktLu+aw2ax9c06Rou7p46yWeze9ZTVgd3jyaaLjB575v9g9ejbsorRY8Xq7+weXUeu s3l83iQXwBbFZZOSmpNZllqkb5fAlfFibWrBJs6K5196WBoYf7N3MXJySAiYSKzf8YAJwhaT uHBvPVsXIxeHkMAsRokTzdOgnJ+MEpe33GYGqWITMJT4+eI1UAcHh4iAnMTOM5UgNcwCWxkl Jj7/BFYjLBAp8fTNNbCpLAKqEtOfbWYEsXkFPCTudS5gBemVEFCQmDPJZgIj9wJGhlWMEqkF yQXFSem5hnmp5XrFibnFpXnpesn5uZsYwSHzTGoH48Fd7ocYBTgYlXh4IxhEwoVYE8uKK3MP MUpwMCuJ8L5+BxTiTUmsrEotyo8vKs1JLT7EKM3BoiTO+/j/ujAhgfTEktTs1NSC1CKYLBMH p1QDY5+ioGZh2LUVtw7JKor3Vn00eP1eeXfOEzbTo8WCXBMOP5n/c8n65Rx7NnVwr3domW35 7k1yTeCF0qdn384oyM1MVrFIT1npFm+zizMvWGZ3/N7WjuVHCxdv23LqnKnWlpvSG2uP3Ni6 X2LFgu1+IabpqodP6xwuDj4vZDQ1as4prennM049e6LEUpyRaKjFXFScCAA2Fh01FQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Parameters delay_on and delay_off of led_trigger_blink_oneshot() are pointers, to enable blink interval adjustment by LED class drivers of the controllers that implement hardware blinking. Move ide_blink_delay variable to ledtrig_ide_activity() in order to prevent the situation when adjustment committed by one LED class driver influences blink interval of the software fallback blink feature, that is applied to the drivers that don't implement blink_set op. Signed-off-by: Jacek Anaszewski --- drivers/leds/trigger/ledtrig-ide-disk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/leds/trigger/ledtrig-ide-disk.c b/drivers/leds/trigger/ledtrig-ide-disk.c index c02a3ac..15123d3 100644 --- a/drivers/leds/trigger/ledtrig-ide-disk.c +++ b/drivers/leds/trigger/ledtrig-ide-disk.c @@ -18,10 +18,11 @@ #define BLINK_DELAY 30 DEFINE_LED_TRIGGER(ledtrig_ide); -static unsigned long ide_blink_delay = BLINK_DELAY; void ledtrig_ide_activity(void) { + unsigned long ide_blink_delay = BLINK_DELAY; + led_trigger_blink_oneshot(ledtrig_ide, &ide_blink_delay, &ide_blink_delay, 0); } -- 1.7.9.5