linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wang Nan <wangnan0@huawei.com>
To: <acme@kernel.org>, <jolsa@redhat.com>, <namhyung@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <pi3orama@163.com>,
	Wang Nan <wangnan0@huawei.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Zefan Li <lizefan@huawei.com>, He Kuang <hekuang@huawei.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH v6 4/7] perf record: Force enable --timestamp-filename when --switch-output is provided
Date: Wed, 20 Apr 2016 18:59:51 +0000	[thread overview]
Message-ID: <1461178794-40467-5-git-send-email-wangnan0@huawei.com> (raw)
In-Reply-To: <1461178794-40467-1-git-send-email-wangnan0@huawei.com>

Without this patch, the last output doesn't have timestamp appended if
--timestamp-filename is not explicitly provided. For example:

  # perf record -a --switch-output &
  [1] 11224
  # kill -s SIGUSR2 11224
  [ perf record: dump data: Woken up 1 times ]
  # [ perf record: Dump perf.data.2015122622372823 ]

  # fg
  perf record -a --switch-output
  ^C[ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 0.027 MB perf.data (540 samples) ]

  # ls -l
  total 836
  -rw------- 1 root root  33256 Dec 26 22:37 perf.data   <---- *Odd*
  -rw------- 1 root root 817156 Dec 26 22:37 perf.data.2015122622372823

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1460643725-167413-4-git-send-email-wangnan0@huawei.com
Signed-off-by: He Kuang <hekuang@huawei.com>
[ Updated man page, that also got an entry for --timestamp-filename ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Documentation/perf-record.txt | 5 +++++
 tools/perf/builtin-record.c              | 3 +++
 2 files changed, 8 insertions(+)

diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
index a77a431..79a8a14 100644
--- a/tools/perf/Documentation/perf-record.txt
+++ b/tools/perf/Documentation/perf-record.txt
@@ -347,6 +347,9 @@ Configure all used events to run in kernel space.
 --all-user::
 Configure all used events to run in user space.
 
+--timestamp-filename
+Append timestamp to output file name.
+
 --switch-output::
 Generate multiple perf.data files, timestamp prefixed, switching to a new one
 when receiving a SIGUSR2.
@@ -355,6 +358,8 @@ A possible use case is to, given an external event, slice the perf.data file
 that gets then processed, possibly via a perf script, to decide if that
 particular perf.data snapshot should be kept or not.
 
+Implies --timestamp-filename.
+
 SEE ALSO
 --------
 linkperf:perf-stat[1], linkperf:perf-list[1]
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 72246e2..3676af4 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -1344,6 +1344,9 @@ int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused)
 		return -EINVAL;
 	}
 
+	if (rec->switch_output)
+		rec->timestamp_filename = true;
+
 	if (!rec->itr) {
 		rec->itr = auxtrace_record__init(rec->evlist, &err);
 		if (err)
-- 
1.8.3.4

  parent reply	other threads:[~2016-04-20 19:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-20 18:59 [PATCH v6 0/7] perf tools: Use SIGUSR2 control data dumpping Wang Nan
2016-04-20 18:59 ` [PATCH v6 1/7] perf tools: Introduce trigger class Wang Nan
2016-05-01  7:39   ` [tip:perf/core] " tip-bot for Wang Nan
2016-04-20 18:59 ` [PATCH v6 2/7] perf tools: Derive trigger class from auxtrace_snapshot Wang Nan
2016-04-26 13:54   ` Arnaldo Carvalho de Melo
2016-04-27  9:10     ` Adrian Hunter
2016-05-01  7:39   ` [tip:perf/core] " tip-bot for Wang Nan
2016-04-20 18:59 ` [PATCH v6 3/7] perf record: Split output into multiple files via '--switch-output' Wang Nan
2016-04-27 21:32   ` Arnaldo Carvalho de Melo
2016-04-29  4:56     ` Wangnan (F)
2016-05-01  7:39   ` [tip:perf/core] " tip-bot for Wang Nan
2016-04-20 18:59 ` Wang Nan [this message]
2016-05-01  7:40   ` [tip:perf/core] perf record: Force enable --timestamp-filename when --switch-output is provided tip-bot for Wang Nan
2016-04-20 18:59 ` [PATCH v6 5/7] perf record: Disable buildid cache options by default in switch output mode Wang Nan
2016-05-01  7:40   ` [tip:perf/core] " tip-bot for Wang Nan
2016-04-20 18:59 ` [PATCH v6 6/7] perf record: Re-synthesize tracking events after output switching Wang Nan
2016-04-20 18:59 ` [PATCH v6 7/7] perf record: Generate tracking events for process forked by perf Wang Nan
2016-05-01  7:41   ` [tip:perf/core] " tip-bot for Wang Nan
2016-04-22 10:30 ` [PATCH v6 0/7] perf tools: Use SIGUSR2 control data dumpping Jiri Olsa
2016-04-27 21:40 ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461178794-40467-5-git-send-email-wangnan0@huawei.com \
    --to=wangnan0@huawei.com \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mhiramat@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=pi3orama@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).